Re-add content search type

[tobiasKaminsky]

Depends on nextcloud/android-library#319

❗ Stalled by nextcloud/android-library#319 ❗
Should be based upon photoSearchLimit branch.

[ezaquarii]

This is completely new fragment and I believe we could greatly benefit from using ViewModel here. View models greatly improve testability.

[tobiasKaminsky]

@ezaquarii I messed something up. I wanted to split up #2250 so that #2250 does not contain any "content search type".
Now it seems that both PRs have the same changes to master and so your comments need to be in #2250.
I'll check them and change them in #2250 and after that try to rebase this PR to be ontop of #2250, also changing the base branch here in github.

[tobiasKaminsky]

This is completely new fragment and I believe we could greatly benefit from using ViewModel here. View models greatly improve testability.

While this is a new fragment, it is "only" a subset of OCFileListFragemnt, which is a subclass of ExtendedListFragment.

Indeed, we should change this, but please not in this PR.

[tobiasKaminsky]

All further discussion should go in #2250 as this PR will be based on it.

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11453.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

299

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423

[codecov]

Codecov Report

Merging #4233 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4233      +/-   ##
============================================
- Coverage     17.45%   17.44%   -0.02%     
  Complexity        3        3              
============================================
  Files           376      376              
  Lines         32309    32314       +5     
  Branches       4560     4561       +1     
============================================
- Hits           5640     5636       -4     
- Misses        25765    25772       +7     
- Partials        904      906       +2

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0% <ø> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java	25.5% <0%> (-0.48%)	0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java	44.53% <0%> (-0.21%)	0 <0> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java	22.79% <0%> (-0.57%)	0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	20.25% <0%> (+0.08%)	0% <0%> (ø)	⬇️