(temporary) fix for navigation issue

[tobiasKaminsky]

For 3.9. I'll do a complete rewrite of navigation flow:

• get rid of event bus
• each search in an own fragment
• lifecycle aware

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[tobiasKaminsky]

/backport to stable-3.8

[nextcloud-android-bot]

Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10873

[AndyScherzinger]

It seems better than before. The original issue seems fixed so that'll work for 3.8.0 while I agree with Tobias that navigation needs a proper post 3.8.0 rewrite

[AndyScherzinger]

❗️ rebased and fixed a spotbugs issue to fix build.

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10879.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

275

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	141
Total	429

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	47
Dodgy code Warnings	141
Total	429

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@863261b). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4482   +/-   ##
=========================================
  Coverage          ?   16.96%           
  Complexity        ?        3           
=========================================
  Files             ?      364           
  Lines             ?    32085           
  Branches          ?     4517           
=========================================
  Hits              ?     5442           
  Misses            ?    25745           
  Partials          ?      898

Impacted Files	Coverage Δ	Complexity Δ
...owncloud/android/ui/adapter/OCFileListAdapter.java	28.48% <ø> (ø)	0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java	25.37% <0%> (ø)	0 <0> (?)
...cloud/android/ui/activity/FileDisplayActivity.java	19.72% <0%> (ø)	0 <0> (?)
...om/owncloud/android/ui/fragment/PhotoFragment.java	0% <0%> (ø)	0 <0> (?)
...m/owncloud/android/ui/activity/DrawerActivity.java	44.82% <0%> (ø)	0 <0> (?)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@863261b). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4482   +/-   ##
=========================================
  Coverage          ?   16.96%           
  Complexity        ?        3           
=========================================
  Files             ?      364           
  Lines             ?    32085           
  Branches          ?     4517           
=========================================
  Hits              ?     5442           
  Misses            ?    25745           
  Partials          ?      898

Impacted Files	Coverage Δ	Complexity Δ
...owncloud/android/ui/adapter/OCFileListAdapter.java	28.48% <ø> (ø)	0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java	25.37% <0%> (ø)	0 <0> (?)
...cloud/android/ui/activity/FileDisplayActivity.java	19.72% <0%> (ø)	0 <0> (?)
...om/owncloud/android/ui/fragment/PhotoFragment.java	0% <0%> (ø)	0 <0> (?)
...m/owncloud/android/ui/activity/DrawerActivity.java	44.82% <0%> (ø)	0 <0> (?)

[backportbot-nextcloud]

backport to stable-3.8 in #4485