Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.8] (temporary) fix for navigation issue #4485

Merged
merged 2 commits into from Sep 10, 2019

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4482

tobiasKaminsky and others added 2 commits September 10, 2019 04:44
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10886.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.8PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

SpotBugs (stable-3.8)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (stable-3.8@d94fa72). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             stable-3.8    #4485   +/-   ##
=============================================
  Coverage              ?   16.64%           
  Complexity            ?        1           
=============================================
  Files                 ?      360           
  Lines                 ?    31991           
  Branches              ?     4510           
=============================================
  Hits                  ?     5324           
  Misses                ?    25789           
  Partials              ?      878
Impacted Files Coverage Δ Complexity Δ
...owncloud/android/ui/adapter/OCFileListAdapter.java 24.47% <ø> (ø) 0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.37% <0%> (ø) 0 <0> (?)
...cloud/android/ui/activity/FileDisplayActivity.java 17.89% <0%> (ø) 0 <0> (?)
...om/owncloud/android/ui/fragment/PhotoFragment.java 0% <0%> (ø) 0 <0> (?)
...m/owncloud/android/ui/activity/DrawerActivity.java 44.46% <0%> (ø) 0 <0> (?)

1 similar comment
@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (stable-3.8@d94fa72). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             stable-3.8    #4485   +/-   ##
=============================================
  Coverage              ?   16.64%           
  Complexity            ?        1           
=============================================
  Files                 ?      360           
  Lines                 ?    31991           
  Branches              ?     4510           
=============================================
  Hits                  ?     5324           
  Misses                ?    25789           
  Partials              ?      878
Impacted Files Coverage Δ Complexity Δ
...owncloud/android/ui/adapter/OCFileListAdapter.java 24.47% <ø> (ø) 0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.37% <0%> (ø) 0 <0> (?)
...cloud/android/ui/activity/FileDisplayActivity.java 17.89% <0%> (ø) 0 <0> (?)
...om/owncloud/android/ui/fragment/PhotoFragment.java 0% <0%> (ø) 0 <0> (?)
...m/owncloud/android/ui/activity/DrawerActivity.java 44.46% <0%> (ø) 0 <0> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants