Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shot from 3.1.0 to 4.1.1 #5927

Merged
merged 3 commits into from Jun 5, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 24, 2020

Bumps shot from 3.1.0 to 4.1.1.

Release notes

Sourced from shot's releases.

Fix crash by runtime exception thrown by the Facebook library

No release notes provided.

First shot-android release and major library usability improvements.

Include shot-android module as part of the plugin implementation. Provide a custom test runner and a handy interface to write tests. Improve documentation with the new tools ready to use.

Improved flavor support and update tasks names change

This release contains major breaking changes related to Shot configuration and also updates the name of the tasks created by Shot when the plugin is configured. This major release also simplifies the configuration of this gradle plugin so there is no need to specify the app id and the testing target to use. In case of any doubt review the project READEM.md file or feel free to ask the contributors anything.

Commits
  • c8f1f32 Prepare release 4.1.1
  • 6a3b698 Prepare next development iteeration
  • 3495efd Prepare release 4.1.0
  • b59a5fa Improve documentation and main screenshot test interface
  • 19ec35b Merge pull request #98 from Karumi/integrate-new-shot-android-module
  • 9b82ed2 Merge pull request #99 from hamorillo/master
  • 5273662 Cursor test simplified
  • 74a583a Implemented new activity with just an editText
  • a5ccb01 Removed unnecessary imports
  • 1f08788 Refactor disable flaky test
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @AndyScherzinger.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Apr 24, 2020
@nextcloud-android-bot
Copy link
Collaborator

Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.13.0 milestone Apr 28, 2020
@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.karumi-shot-4.1.1 branch from 42f743f to 7221131 Compare April 29, 2020 11:55
@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@nextcloud-android-bot
Copy link
Collaborator

Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.karumi-shot-4.1.1 branch from 7221131 to 49042f1 Compare May 8, 2020 12:04
@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.karumi-shot-4.1.1 branch from 49042f1 to 19487c3 Compare May 8, 2020 13:28
@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@dependabot-preview
Copy link
Contributor Author

A newer version of com.karumi:shot exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.karumi-shot-4.1.1 branch from 16b5901 to 30ee8fc Compare June 4, 2020 11:34
@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

dependabot-preview bot and others added 3 commits June 5, 2020 08:06
Bumps [shot](https://github.com/karumi/shot) from 3.1.0 to 4.1.1.
- [Release notes](https://github.com/karumi/shot/releases)
- [Changelog](https://github.com/Karumi/Shot/blob/master/release.gradle)
- [Commits](pedrovgs/Shot@3.1.0...4.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.karumi-shot-4.1.1 branch from 30ee8fc to 80d83e4 Compare June 5, 2020 06:07
Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

See the complete overview on Codacy

sleep 2
adb shell "echo $IP server >> /system/etc/hosts"

sed -i s'#<bool name="is_beta">false</bool>#<bool name="is_beta">true</bool>#'g src/main/res/values/setup.xml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


mv gradle.properties_ gradle.properties
sed -i s'#<bool name="is_beta">true</bool>#<bool name="is_beta">false</bool>#'g src/main/res/values/setup.xml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14372.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Codacy

390

Lint

TypemasterPR
Warnings9595
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total371

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total371

@tobiasKaminsky tobiasKaminsky merged commit b996cce into master Jun 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the dependabot/gradle/com.karumi-shot-4.1.1 branch June 5, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants