Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up AccountRemovalWork #9644

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Clean up AccountRemovalWork #9644

merged 1 commit into from
Jan 5, 2022

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9644.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #9644 (90d66c4) into master (3f8adc1) will increase coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #9644      +/-   ##
==========================================
+ Coverage   30.99%   31.19%   +0.19%     
==========================================
  Files         502      504       +2     
  Lines       38409    38547     +138     
  Branches     5342     5380      +38     
==========================================
+ Hits        11906    12024     +118     
+ Misses      24723    24702      -21     
- Partials     1780     1821      +41     
Impacted Files Coverage Δ
...va/com/nextcloud/client/jobs/AccountRemovalWork.kt 0.00% <0.00%> (ø)
.../com/nextcloud/client/jobs/BackgroundJobFactory.kt 66.98% <0.00%> (-0.64%) ⬇️
...n/java/com/nextcloud/client/di/ViewModelFactory.kt 27.27% <0.00%> (-12.73%) ⬇️
...xtcloud/client/onboarding/OnboardingServiceImpl.kt 59.09% <0.00%> (-4.55%) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 32.12% <0.00%> (-2.01%) ⬇️
...ain/java/com/owncloud/android/db/UploadResult.java 41.02% <0.00%> (-1.29%) ⬇️
.../com/owncloud/android/datamodel/MediaProvider.java 23.76% <0.00%> (-0.98%) ⬇️
...ncloud/android/operations/UploadFileOperation.java 60.45% <0.00%> (-0.50%) ⬇️
...ava/com/owncloud/android/files/FileMenuFilter.java 51.45% <0.00%> (-0.45%) ⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java 36.71% <0.00%> (-0.11%) ⬇️
... and 24 more

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings124124
Errors00

SpotBugs (new)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 69
Security Warnings 29
Dodgy code Warnings 358
Total 642

SpotBugs (master)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 69
Security Warnings 29
Dodgy code Warnings 358
Total 642

@tobiasKaminsky tobiasKaminsky merged commit 7d4fa29 into master Jan 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the cleanUpAccountRemoval branch January 5, 2022 14:05
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.19.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants