Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app-discover API #1302

Merged
merged 54 commits into from Mar 6, 2024
Merged

feat: app-discover API #1302

merged 54 commits into from Mar 6, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 19, 2024

This includes the data format documentation for the app-discover section. Including the schema for validation.

Screenshot 2024-02-19 at 19-42-04 Appstore discover section API — AppStore 4 3 3 documentation

@bigcat88
Copy link
Member

Should AppStore perform validation on upload?
Or it will be done in "upload script" before uploading?

@susnux
Copy link
Contributor Author

susnux commented Feb 19, 2024

I would do it on upload by the appstore (and just return 400 if not valid), there are some good libraries:

https://json-schema.org/implementations#validators-python

But if that is too complex just return the uploaded file.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
pre-commit-ci bot and others added 10 commits February 19, 2024 23:19
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.2.1 → v0.2.2](astral-sh/ruff-pre-commit@v0.2.1...v0.2.2)
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
Copy link
Member

I was not able to generate json file that will pass the validation..

@bigcat88 bigcat88 changed the title feat: Add documentation for the app-discover API feat: app-discover API Feb 22, 2024
@susnux
Copy link
Contributor Author

susnux commented Feb 22, 2024

An example that validates (I use jschon locally):

example.json

bigcat88 and others added 9 commits February 22, 2024 18:01
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
nextcloud-bot and others added 6 commits March 3, 2024 02:46
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Update dependency django-allauth to ^0.61.0
Copy link

github-actions bot commented Mar 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

nextcloud-bot and others added 12 commits March 5, 2024 02:48
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Broken templates after django-allauth update
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
host documentation on the GitHub
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
susnux and others added 5 commits March 6, 2024 18:31
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
…/app-discover-API

# Conflicts:
#	poetry.lock
@bigcat88 bigcat88 marked this pull request as ready for review March 6, 2024 15:36
@bigcat88 bigcat88 merged commit 6f88156 into master Mar 6, 2024
12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/app-discover-API branch March 6, 2024 16:13
@susnux susnux mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants