Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework archive functions to avoid undefinded keys #2163

Merged
merged 2 commits into from
May 29, 2024

Conversation

solracsf
Copy link
Member

Fix:

Undefined array key 0 at /var/www/nextcloud/apps/bookmarks/lib/Service/CrawlService.php#124

and other small code optimizations.

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, that was some butt ugly code 🙈

@marcelklehr marcelklehr merged commit 41ca553 into master May 29, 2024
48 of 50 checks passed
@marcelklehr marcelklehr deleted the archiveUndefinedFix branch May 29, 2024 09:01
@marcelklehr
Copy link
Member

Thanks a ton @solracsf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants