-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public calendar iframe has issues on some browsers #169
Comments
@georgehrke Can you test on Safari ? |
The Chrome error is |
@tcitworld Do you have some example code for me? |
ping @tcitworld ^ :) |
For instance this one works with Firefox and Chromium but not Chrome on Linux : http://www.berrylab36.org/Ouverture Here it's embeed within SPIP but I've heard of the same issue with a Wordpress. Will try myself. |
Safari 10 on macOS works just fine for me. |
I see a few issues here. Further Chrom(e|ium) doesn't support X-Frame-Options. Also Chrom(e|ium) got more strict about https lately. Maybe @LukasReschke has more insights here |
IE doesn't work for the same reason the calendar app itself doesn't work in Internet explorer. Should we display some overlay asking the user to use a different webbrowser? |
I guess this needs some tweaking. |
Will see how nextcloud/server#1472 handles things. |
I can confirm this. |
Maybe my Ǹextcloud is to secure? Firefox
|
@LukasReschke ping :) |
At least IE 11 should be fixed by now |
Seeing the same " redirected you too many times" in both Opera 43.0.2442.1165 and Chrome 57.0.2987.110. In Firefox 52.0.1 only seeing blank iframe. (macOS 10.12, all 64 bit browsers) |
We don't support Opera. Will definitely look into the Chrome and Firefox issue |
When I used http://www.tinywebgallery.com/blog/advanced-iframe/free-iframe-checker |
This requires changes to the Nextcloud server, to be released with Nextcloud 12. |
Still seeing this issue on Nextcloud 12 and Chrome. tl; dr - firefox and safari work, Chrome throws a redirect error. |
Error still exists. |
@Ich5003 What Browser, Nextcloud version, calendar app version? |
Thanks to nextcloud/server#11433 we should be good with NC15. |
Yes you should. |
@rullzer I tested and we're still blocked by https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/Middleware/Security/SameSiteCookieMiddleware.php#L60-L61 which triggers 302s for every request. |
Ah ok. So the check I had in mind doesn't fully work. As that would with the current logic log you out of your nextcloud if you embed a page. Thinking more this would need a few adjustments
|
Works perfectly ! Will send PRs. :) |
Fixes #169 (will probably require NC 15 though) Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Which can be used for public iframe embeeding See nextcloud/calendar#169 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Which can be used for public iframe embeeding See nextcloud/calendar#169 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Same issue. Embed code generate this error :`
|
Using the embed link on a recent NC 18, I am receiving
Consequently Firefox block the content loading, even from a parent domain (X-Frame-Option is ignored when CSP is defined). Afaik there is no option in NC to define a « trusted embeder ». Moreover, may be the embed link should allow anyone to embed. I overcame the situation by munging Content-Security-Policy by this kludge on my reverse proxy:
|
A fixis already in master. and will be in the next release. |
Hello, NC 18.0.6 and I still have this problem. I even added the headers mentionned by @fpoulain ( |
Same here. |
It should work on Nextcloud 19. There are known issues with Nextcloud 18 and below. |
I updated to NC 19 (on the beta channel), it still doesn't work. With Chrome, I still see these errors in the console coming from the calendar url when I browse the page with an iframe: |
We updated to NC19 and still have the same issue; firefox requests still returning a 503; chrome is fine. |
There are also a problem with embeding it in wordpress |
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: