Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] The public links doesn't work in a iframe #74

Closed
cyrzero opened this issue May 7, 2020 · 5 comments
Closed

[Feature] The public links doesn't work in a iframe #74

cyrzero opened this issue May 7, 2020 · 5 comments

Comments

@cyrzero
Copy link

cyrzero commented May 7, 2020

This application is very useful, thank you !
I try to integrate public link in a Worpress Website.
i use iframe and allow all.
I configured Header X-Options in Apache2 and .htaccess .

Some shared links in nextcloud like calendar link work in my iframe but not for reserved appointments...
Capture du 2020-05-07 16-54-42

@cyrzero cyrzero changed the title The public links doesn't work in a iframe [BUG] The public links doesn't work in a iframe May 7, 2020
@SergeyMosin SergeyMosin changed the title [BUG] The public links doesn't work in a iframe [Feature] The public links doesn't work in a iframe May 7, 2020
@SergeyMosin
Copy link
Owner

This is more of security feature than a bug. Here is more info: https://w3c.github.io/webappsec-csp/#directive-frame-ancestors
However, I guess there could be admin level override for this

@nickian
Copy link

nickian commented May 21, 2020

This would be much more useful if it could be embedded as an iframe or with a javascript tag. Is there an easy way to tell nginx or Apache to allow it?

@SergeyMosin
Copy link
Owner

I think @NoSameSiteCookieRequired annotation (nextcloud/user_saml#159 and nextcloud/calendar#169) is needed in the code and an option to add domains/urls into which the "public appointments page" is going to be embedded as per #74 (comment).

Next release should be good for embedding.

@SergeyMosin
Copy link
Owner

v1.5.0
iframe embeddable URL is available under Public Page [...] > Show URL/link > Show iframe/embeddable
Plus additional instruction in the Help/Tutorial section

@cyrzero
Copy link
Author

cyrzero commented Jun 9, 2020

Thank you ! I will try that wen i have some time.

@cyrzero cyrzero closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants