Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated text / layout of event boxes has some issues #4332

Closed
jancborchardt opened this issue Jun 29, 2022 · 20 comments
Closed

Updated text / layout of event boxes has some issues #4332

jancborchardt opened this issue Jun 29, 2022 · 20 comments
Assignees
Labels
2. developing Work in progress blocked This ticket or PR is blocked by another one bug design Related to design, interface, interaction design, UX, etc. Feature: Fullcalendar regression Regression of a previous working feature
Milestone

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Jun 29, 2022

Steps to reproduce

  1. Open any of the views except list view
  2. See that there’s weird line breaking between time and title which wasn’t there before

Not sure if this has to do either with the introduction of the icons for events being shared and having reminders, or changing from ellipsizing to showing the full event name, or both.

Expected behavior

Month view should only have 1 line per event. Only show start time of the event, and ellipsize the title. Icons for reminder and shared state are not necessary here as there is simply no space. Ref Google Calendar and Outlook (note Outlook has these "event icons" in front of the title which can be customized, let’s ignore those):
image
image


Week view and day view should have the text of the event first. The time (both beginning and end) in the last possible line, and the icons if at all can go on the same line as the time, on the right. That way it doesn’t cut anything from the title.
image

Outlook doesn’t even show the time in the event bubble itself (which I find a bit too little info tbh and especially for Friday/Sat/Sun events you have to jump to the left:
image

Actual behaviour

There is always 1 line with the time and then it breaks for the text:
image

In the day and week view there was even this curiosity – first even breaks without needing to, and the second event for some reason has a small title?
image

Calendar app version

3.4.0

Browser

Firefox 102.0b7

Client operating system

Ubuntu 20.04

Server operating system

cloud.nextcloud.com

Nextcloud version

24

@jancborchardt jancborchardt added bug 0. to triage Pending approval or rejection 1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. Feature: Fullcalendar regression Regression of a previous working feature and removed 0. to triage Pending approval or rejection labels Jun 29, 2022
@Zaxooy
Copy link

Zaxooy commented Jun 29, 2022

Just to add another point of this issue: After the latest update (3.4.1) in the monthly view the colors of events having a time are missing (tried 2 different browsers):
grafik

@quentinDupont
Copy link

I confirm that after 3.4.1 update, color desapears on events in monthly view (except for event during all day long)
Same issue or we create an other one ?

@ChristophWurst
Copy link
Member

That is because of #4324. We had to accept the design regression so the calendar renders at least.

Same issue or we create an other one ?

#4290.

@dinosmm
Copy link

dinosmm commented Jun 30, 2022

This is a much better report for #4316, am I understanding correctly that these layout problems have now been acknowledged as a bug and will be worked on for a future version?

@daumas-git
Copy link

For me the events overflow on the others, with last version :
image

@genofire
Copy link

genofire commented Jul 2, 2022

Same problem like @daumas-git -> we downgrade from 3.4.1 to 3.3.2 - (no idea when this happens on 3.4.0 or 3.4.1)

@manicmarvin

This comment was marked as duplicate.

@ygoe

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@ygoe

This comment was marked as resolved.

@pm-pm

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jul 5, 2022
@ChristophWurst ChristophWurst added this to the 3.4.2 milestone Jul 5, 2022
@JuliaKirschenheuter JuliaKirschenheuter added the blocked This ticket or PR is blocked by another one label Jul 6, 2022
@ChristophWurst
Copy link
Member

Fixed with #4351

@JuliaKirschenheuter
Copy link
Contributor

I've started to fix several visual bugs. But then saw very weird behavior with reactivity #4336 and #4334. Right now it is not possible to continue with this ticket, because the way of using EventRender.vue is unfortunately wrong, and as an easy/quick fix was to revert this changes: #4351.

  • First the right way of using EventRender.vue should be found
  • Then the design / css could be adapted to the new structure

@miaulalala
Copy link
Contributor

I just released a pre- release for Calendar (v3.4.2-RC.1). Can people test and give us feedback if possible?

Thanks!!! 🙏

@rigrig
Copy link

rigrig commented Jul 6, 2022

From a quick test: seems to work OK for me.
Tested:

  • switched between Day/Week/Month/List view (Month was broken for me with 3.4.1, now fixed in v3.4.2-RC.1)
    • single-day events with time get a colored circle
    • full-day events, and events spanning multiple days get solid calendar background color
    • events with too-long-to-fit titles are truncated so they fit (with ellipsis…) exactly in a column
  • created an event
  • dragged the event to a different day

@dinosmm
Copy link

dinosmm commented Jul 6, 2022

  * events with too-long-to-fit titles are truncated so they fit (with ellipsis…) exactly in a column

I am away and not able to test this at the moment - are events now back on a single line in month view, regardless of whether they have a notification icon or not?

@rigrig
Copy link

rigrig commented Jul 6, 2022

They are back on a single line, but without any icons:
image

Didn't think to test that before, but setting a reminder does not show up as icon (in any view mode)

@miaulalala
Copy link
Contributor

They are back on a single line, but without any icons: image

Didn't think to test that before, but setting a reminder does not show up as icon (in any view mode)

Yeah this has been reverted (#3162) for now. We're working on getting the events back!

Thanks for testing!

@dinosmm
Copy link

dinosmm commented Jul 6, 2022

Yeah this has been reverted (#3162) for now. We're working on getting the events back!

Once the icons are back, will the events stay as one-liners please, rather than revert to the difficult-to-read two-liner format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress blocked This ticket or PR is blocked by another one bug design Related to design, interface, interaction design, UX, etc. Feature: Fullcalendar regression Regression of a previous working feature
Projects
Development

No branches or pull requests