Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[stable3.4] Fix color dot and event alignment" #4324

Merged
merged 1 commit into from Jun 28, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jun 28, 2022

Fixes #4313

Reverts #4306

Reintroduces #4290

I tested it locally and reverting my commit fixes the problem. I tried to fix this locally but couldn't come up with a better solution for now.

This way we can at least get a release out.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #4324 (99cf38f) into stable3.4 (93757c2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##             stable3.4    #4324      +/-   ##
===============================================
+ Coverage        29.55%   29.57%   +0.02%     
  Complexity         330      330              
===============================================
  Files              221      221              
  Lines             7657     7654       -3     
  Branches          1015     1013       -2     
===============================================
+ Hits              2263     2264       +1     
+ Misses            5394     5390       -4     
Flag Coverage Δ
javascript 20.67% <100.00%> (+0.02%) ⬆️
php 68.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/EventRender.vue 0.00% <ø> (ø)
...c/fullcalendar/eventSources/eventSourceFunction.js 92.98% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcacef...99cf38f. Read the comment docs.

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Jun 28, 2022
@ChristophWurst ChristophWurst added this to the 3.4.1 milestone Jun 28, 2022
@ChristophWurst ChristophWurst merged commit ae2e917 into stable3.4 Jun 28, 2022
@ChristophWurst ChristophWurst deleted the revert-4306-backport/4305/stable3.4 branch June 28, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants