Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Vue event renderer #4351

Merged
merged 2 commits into from Jul 6, 2022
Merged

Revert Vue event renderer #4351

merged 2 commits into from Jul 6, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 6, 2022 •
edited

Reverts #4253 and #4085

Reopens #3162

Short term solution for #4332 until we have the Vue event renderer under control.

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Jul 6, 2022
@ChristophWurst ChristophWurst added bug regression Regression of a previous working feature labels Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022 •
edited

Codecov Report

Merging #4351 (ca2abbb) into main (e35880f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4351      +/-   ##
============================================
+ Coverage     29.38%   29.41%   +0.03%     
  Complexity      330      330              
============================================
  Files           221      220       -1     
  Lines          7718     7703      -15     
  Branches       1024     1019       -5     
============================================
- Hits           2268     2266       -2     
+ Misses         5450     5437      -13
Flag Coverage Δ
javascript 20.51% <ø> (+0.01%) ⬆️
php 68.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/CalendarGrid.vue 0.00% <ø> (ø)
...c/fullcalendar/eventSources/eventSourceFunction.js 92.72% <ø> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35880f...ca2abbb. Read the comment docs.

@ChristophWurst
Copy link
Member Author

Works on my dev instance

@ChristophWurst ChristophWurst marked this pull request as ready for review July 6, 2022 11:30
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 6, 2022
@ChristophWurst
Copy link
Member Author

/backport to stable3.4

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Jul 6, 2022
@ChristophWurst ChristophWurst merged commit 29366c8 into main Jul 6, 2022
@ChristophWurst ChristophWurst deleted the revert/vue-event-renderer branch July 6, 2022 11:52
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 6, 2022
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Jul 6, 2022
This was referenced Jul 6, 2022
Closed
Closed
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jul 6, 2022
Closed
This was referenced Jul 6, 2022
Open
Closed
This was referenced Jul 6, 2022
Open
Closed
Closed
@ChristophWurst ChristophWurst mentioned this pull request Jul 6, 2022
Open
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@tcitworld tcitworld Awaiting requested review from tcitworld

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChristophWurst @JuliaKirschenheuter