Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar resharing is allowed in the UI but not implemented properly in the backend #5755

Closed
st3iny opened this issue Feb 13, 2024 · 0 comments · Fixed by #5757
Closed

Calendar resharing is allowed in the UI but not implemented properly in the backend #5755

st3iny opened this issue Feb 13, 2024 · 0 comments · Fixed by #5757
Assignees

Comments

@st3iny
Copy link
Member

st3iny commented Feb 13, 2024

Steps to reproduce

  1. Ensure that two users A and B exist.
  2. Be user A: Create a calendar and share it with edit permissions with user B.
  3. Be user B: Open the calendar modal and reshare the calendar with someone else.

The same applies if user A shares a calendar to a group.

Expected behavior

It should work as I'm allowed to share.

Actual behaviour

The dav request fails and there is no indication of a failure.

POST 403 https://localhost/remote.php/dav/calendars/admin/reshare-test-direct_shared_by_user/
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\Forbidden</s:exception>
  <s:message/>
</d:error>

The backend reports the incoming share as reshareable which is not correct. Hence the sharing options are shown in the modal.

Screenshot_20240213_134045

Calendar app version

main

Nextcloud version

master

Additional info

Possible solution: Hide the sharing dialogue for now.

@st3iny st3iny added 1. to develop Accepted and waiting to be taken care of bug Feature: Sharing labels Feb 13, 2024
@st3iny st3iny self-assigned this Feb 13, 2024
@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Feb 13, 2024
st3iny added a commit that referenced this issue Feb 13, 2024
Fix #5755

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
backportbot bot pushed a commit that referenced this issue Feb 13, 2024
Fix #5755

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging a pull request may close this issue.

1 participant