Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable resharing of incoming shared calendars #5757

Merged
merged 1 commit into from Feb 13, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 13, 2024

Fix #5755

Before After
grafik grafik grafik grafik

Fix #5755

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added this to the v4.7.0 milestone Feb 13, 2024
@st3iny st3iny self-assigned this Feb 13, 2024
@st3iny
Copy link
Member Author

st3iny commented Feb 13, 2024

/backport to stable4.6

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9d54b96) 24.50% compared to head (c370c11) 24.49%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/EditCalendarModal.vue 0.00% 3 Missing ⚠️
...ts/AppNavigation/CalendarList/CalendarListItem.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5757      +/-   ##
============================================
- Coverage     24.50%   24.49%   -0.01%     
  Complexity      423      423              
============================================
  Files           243      243              
  Lines         10934    10938       +4     
  Branches       1795     1797       +2     
============================================
  Hits           2679     2679              
- Misses         8255     8259       +4     
Flag Coverage Δ
javascript 15.44% <0.00%> (-0.01%) ⬇️
php 61.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 13, 2024
@st3iny st3iny merged commit 7a5a6d6 into main Feb 13, 2024
35 of 37 checks passed
@st3iny st3iny deleted the fix/disable-resharing branch February 13, 2024 16:21
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Feature: Sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar resharing is allowed in the UI but not implemented properly in the backend
2 participants