Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove eventLimit #139

Merged
merged 1 commit into from
Oct 19, 2016
Merged

remove eventLimit #139

merged 1 commit into from
Oct 19, 2016

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented Oct 19, 2016

remove eventLimit as of #134 (comment)

with the recent fixes made to the calendar list, the calendar list won't scroll together with the calendar view.

please review @nextcloud/calendar

@georgehrke georgehrke added the 3. to review Waiting for reviews label Oct 19, 2016
@mention-bot
Copy link

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peternowee to be a potential reviewer.

@coveralls
Copy link

coveralls commented Oct 19, 2016

Coverage Status

Coverage remained the same at 42.891% when pulling d6ad7d2 on ditch_eventLimit into feec09b on master.

@raghunayyar
Copy link
Member

👍

1 similar comment
@tcitworld
Copy link
Member

👍

@georgehrke georgehrke merged commit 03716b8 into master Oct 19, 2016
@georgehrke georgehrke deleted the ditch_eventLimit branch October 19, 2016 19:20
@jancborchardt
Copy link
Member

@georgehrke does the calendar correctly scroll to the current day if it’s the last week of the month as described in #134 (comment) ? :)

@georgehrke
Copy link
Member Author

Not yet, that's gonna be an ugly hack.
I'll create an issue to remind me.

@georgehrke
Copy link
Member Author

#146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants