Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id for CalendarListItemSharingSearch component #2287

Merged
merged 1 commit into from
May 27, 2020

Conversation

georgehrke
Copy link
Member

fixes:

[DOM] Found 2 elements with non-unique id #users-groups-search: (More info: https://goo.gl/9p2vKq) 

We are not using the Id anywhere, not even for a label....

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label May 27, 2020
@georgehrke georgehrke requested a review from tcitworld May 27, 2020 08:28
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #2287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2287   +/-   ##
=========================================
  Coverage     27.63%   27.63%           
  Complexity      103      103           
=========================================
  Files           144      144           
  Lines          5287     5287           
  Branches        798      798           
=========================================
  Hits           1461     1461           
  Misses         3826     3826           
Flag Coverage Δ Complexity Δ
#javascript 22.25% <ø> (ø) 0.00 <ø> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ion/CalendarList/CalendarListItemSharingSearch.vue 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a235d...eedb991. Read the comment docs.

@georgehrke georgehrke merged commit 67ccd00 into master May 27, 2020
@georgehrke georgehrke deleted the bugfix/noid/fix_duplicate_id branch May 27, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants