Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also mark tasks as done when STATUS is set to COMPLETED #2339

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 14, 2020

Description

Follow up to #1798

Tasks might not always have a PERCENT-COMPLETE so tasks with a STATUS of COMPLETED should also get marked as such.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How to test / use your changes?

Add a task with the following data:

VERSION:2.0
PRODID:-//Nextcloud Tasks v0.13.1
BEGIN:VTODO
UID:f4b456d3-4c53-47a9-ae99-4ffdc2817715
CREATED:20200613T224342
LAST-MODIFIED:20200614T111359
DTSTAMP:20200614T111359
SUMMARY:fsdf
DUE:20200620T230000
DTSTART:20200613T230000
COMPLETED:20200614T111359
STATUS:COMPLETED
END:VTODO
END:VCALENDAR

Checklist:

  • My code follows the style guidelines of this project
  • I signed off my changes (git commit -sm "Your commit message")
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added 3. to review Waiting for reviews bug labels Jun 14, 2020
@juliushaertl juliushaertl added this to the 2.1.0 milestone Jun 14, 2020
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #2339 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2339   +/-   ##
=========================================
  Coverage     27.60%   27.60%           
  Complexity      103      103           
=========================================
  Files           145      145           
  Lines          5297     5297           
  Branches        798      798           
=========================================
  Hits           1462     1462           
  Misses         3835     3835           
Flag Coverage Δ Complexity Δ
#javascript 22.23% <100.00%> (ø) 0.00 <0.00> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
src/fullcalendar/eventSourceFunction.js 95.91% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533ad83...096f4f4. Read the comment docs.

Copy link
Contributor

@bfritscher bfritscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@georgehrke
Copy link
Member

Merci!

@georgehrke georgehrke merged commit d9f77d7 into master Jun 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/task-completed branch June 15, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants