Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trashbin being inacessible when the calendar of a deleted object's unavailable #3922

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

tcitworld
Copy link
Member

Fix is very similar to nextcloud/tasks#1873

Closes #3894

…s unavailable

Fix is very similar to nextcloud/tasks#1873

Closes #3894

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added 3. to review Waiting for reviews bug Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI labels Jan 29, 2022
@tcitworld tcitworld added this to the v3.1.0 milestone Jan 29, 2022
@tcitworld
Copy link
Member Author

/backport to stable3.0

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #3922 (5b5162b) into main (9f1c5e1) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3922   +/-   ##
=========================================
  Coverage     29.42%   29.42%           
  Complexity      322      322           
=========================================
  Files           221      221           
  Lines          7578     7578           
  Branches       1001     1002    +1     
=========================================
  Hits           2230     2230           
  Misses         5348     5348           
Flag Coverage Δ
javascript 20.80% <0.00%> (ø)
php 67.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1c5e1...5b5162b. Read the comment docs.

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Access Trash Bin
4 participants