Don't break trashbin if calendar is undefined #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
=========================================
Coverage 30.44% 30.44%
Complexity 41 41
=========================================
Files 66 66
Lines 3134 3134
Branches 585 586 +1
=========================================
Hits 954 954
Misses 2180 2180 |
|
I will merge this now. I created another issue for the second half of the fix: #1875. |
|
Ah, I believe I am experiencing this issue. My trash bin fails to load right now. I think it might be caused by the issue that this merge fixed. |
The fix will come with the next release. In the meantime you might be able to delete the event that breaks the Tasks trash bin from the Calendar app trash bin. |
tcitworld
added a commit
to nextcloud/calendar
that referenced
this pull request
Jan 29, 2022
…s unavailable Fix is very similar to nextcloud/tasks#1873 Closes #3894 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
backportbot-nextcloud bot
pushed a commit
to nextcloud/calendar
that referenced
this pull request
Feb 2, 2022
…s unavailable Fix is very similar to nextcloud/tasks#1873 Closes #3894 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
st3iny
pushed a commit
to nextcloud/calendar
that referenced
this pull request
Feb 8, 2022
…s unavailable Fix is very similar to nextcloud/tasks#1873 Closes #3894 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently only contains the first half of the fix. The trash bin will now properly load and show all deleted items. Deletion also works fine.
But, for deleted events from calendars that only support events (not tasks),
Unknown calendarwill be shown. This is because these calendars are not loaded by the Tasks app by default.In order to make this work properly, we have to load all calendars from the server when opening the trash bin. This also covers calendars that were newly created after the initial load of the app.
Closes #1803.