Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NC12 IEMailTemplate for fancier emails #476

Merged
merged 1 commit into from
May 30, 2017

Conversation

georgehrke
Copy link
Member

fixes #427

email

I didn't find a way to make the calendar name bold yet :/

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
Copy link
Member Author

I'm thinking about adding »« like in the files app

inbox ehrke email 5 238 messages mail today at 5 17 46 pm

@tcitworld
Copy link
Member

I'm thinking about adding »« like in the files app

Makes it quite strange IMHO, as a French, we're not used to see this since we use french quotes « citation » just like regular quotes. Maybe we can leave this up to the translators to choose.

@enoch85
Copy link
Member

enoch85 commented May 26, 2017

Cc @Espina2

@georgehrke georgehrke added this to the 1.6.0-current milestone May 27, 2017
@enoch85
Copy link
Member

enoch85 commented May 28, 2017

What I miss when invited to an event:
Accept | Decline | Maybe (if maybe is an option?)

Also; information about who invited you, which calendar it is (name), time of the event, and place of the event.

The Google pics describes it pretty good in this issue: #427 (Even though the red is not so nice ;) )

@georgehrke
Copy link
Member Author

@enoch85 Server issue ;)

@enoch85
Copy link
Member

enoch85 commented May 28, 2017

@georgehrke

Server issue ;)

So what you mean is that the DAV endpoint doesn't support it? 😮

@georgehrke
Copy link
Member Author

So what you mean is that the DAV endpoint doesn't support it?

The dav end point the part of the server ;)

@enoch85
Copy link
Member

enoch85 commented May 28, 2017

I may be mistaken, but it should be possible to extract the info that you can type in, because you can add info about:

  • Attendee
  • Time
  • Place
  • Who invited you is just about showing the name of the sender which could be extacted from the Display name (right?)

Or do you mean that Accept | Decline | Maybe (if maybe is an option?) is not possible?

@georgehrke
Copy link
Member Author

georgehrke commented May 28, 2017

Yes, that's possible. But not the calendar app but the server sends out the invitation emails ;)

although Accept | Decline | Maybe requires obviously a bit more work than just adding a fancy mail theme

@enoch85
Copy link
Member

enoch85 commented May 28, 2017

Aah, I should go to bed now :)

@enoch85
Copy link
Member

enoch85 commented May 28, 2017

Design wise 👍

When you fixed the bold ;)

@Espina2
Copy link

Espina2 commented May 29, 2017

@georgehrke @enoch85 if you want to highlight something just use a plain bold. It should be enough.

@georgehrke
Copy link
Member Author

Hm, sorry for this stupid question, but what do you mean with plain bold?

<b> </b> doesn't work

@enoch85
Copy link
Member

enoch85 commented May 30, 2017

@Espina2

Hm, sorry for this stupid question, but what do you mean with plain bold?

Ping

@Espina2
Copy link

Espina2 commented May 30, 2017

<strong> is the html default markup for bold

@georgehrke
Copy link
Member Author

<strong> will be escaped just like <b>

@georgehrke
Copy link
Member Author

check the first screenshot. It shows <b>Geburtstage von Freunden</b>.

If I use <strong>, it will just be <strong>Geburtstage von Freunden</strong>.

@georgehrke
Copy link
Member Author

I don't seem to find a way to add bold text looking thru the EMailTemplate.php

Let's go with »« for now. Translators will have the chance to replace that with "" or any other local standard.

@enoch85
Copy link
Member

enoch85 commented May 30, 2017

Let's go with »« for now. Translators will have the chance to replace that with "" or any other local standard.

Let's do this! 🚀

@enoch85 enoch85 merged commit 18a9202 into master May 30, 2017
@georgehrke
Copy link
Member Author

No No No 🙈

@enoch85
Copy link
Member

enoch85 commented May 30, 2017

Oops :D

@georgehrke
Copy link
Member Author

@enoch85 Please don't merge stuff with "2 - developing" ;)

@enoch85
Copy link
Member

enoch85 commented May 30, 2017

Aiai sir 👍

@georgehrke georgehrke deleted the feature/427/use_NC12_emailtemplate branch May 30, 2017 17:13
@georgehrke
Copy link
Member Author

I will just open a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better designed emails when sharing calendar
4 participants