Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nc12 emailtemplate follow up #483

Merged
merged 2 commits into from
Jun 10, 2017

Conversation

georgehrke
Copy link
Member

No description provided.

@georgehrke georgehrke added the 3. to review Waiting for reviews label May 30, 2017
@georgehrke georgehrke added this to the 1.6.0-current milestone May 30, 2017
@georgehrke georgehrke requested a review from tcitworld May 30, 2017 18:31
@georgehrke
Copy link
Member Author

follow up for #476

@georgehrke
Copy link
Member Author

screenshot

@enoch85 enoch85 self-requested a review June 9, 2017 15:57
@enoch85
Copy link
Member

enoch85 commented Jun 9, 2017

👍

@georgehrke georgehrke merged commit fa78964 into master Jun 10, 2017
@georgehrke georgehrke deleted the feature/427/use_NC12_emailtemplate_follow_up branch June 10, 2017 07:50
@jancborchardt
Copy link
Member

The body text completely duplicates the title though … this is not really necessary, and we should simplify it.

@georgehrke
Copy link
Member Author

@jancborchardt Can you suggest a different body text? :)

I'd be happy to change it

@jancborchardt
Copy link
Member

I would just show the header and the button, nothing more. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants