Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webcal): Thunderbird holiday subscription picker #5167

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Apr 27, 2023

For #962

Bildschirmfoto vom 2023-04-28 10-36-37

Todo

  • Design work
  • Subscribe handling

@ChristophWurst ChristophWurst added 2. developing Work in progress enhancement New feature request Feature: WebCal labels Apr 27, 2023
@ChristophWurst ChristophWurst self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 5.74% and project coverage change: -0.16 ⚠️

Comparison is base (5f071dd) 22.58% compared to head (2687af3) 22.42%.

❗ Current head 2687af3 differs from pull request most recent head 1de6116. Consider uploading reports for the commit 1de6116 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5167      +/-   ##
============================================
- Coverage     22.58%   22.42%   -0.16%     
  Complexity      373      373              
============================================
  Files           236      237       +1     
  Lines         11480    11570      +90     
  Branches       2152     2174      +22     
============================================
+ Hits           2593     2595       +2     
- Misses         8887     8975      +88     
Flag Coverage Δ
javascript 13.90% <5.74%> (-0.12%) ⬇️
php 63.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø)
...ponents/Subscription/HolidaySubscriptionPicker.vue 0.00% <0.00%> (ø)
src/store/calendars.js 0.00% <0.00%> (ø)
src/services/caldavService.js 31.74% <31.25%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst ChristophWurst marked this pull request as ready for review April 28, 2023 09:12
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 28, 2023
Copy link
Contributor

@JohannesGGE JohannesGGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the feat/integrated-thunderbird-holidays branch from 2687af3 to 1de6116 Compare April 28, 2023 10:06
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 28, 2023
@ChristophWurst ChristophWurst merged commit 3977b5e into main Apr 28, 2023
@ChristophWurst ChristophWurst deleted the feat/integrated-thunderbird-holidays branch April 28, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request Feature: WebCal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants