fix(Public-Sharing): Show footer with server details and eventual ToS through PublicTemplateResponse #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5184 +/- ##
=============================================
+ Coverage 22.42% 63.94% +41.51%
Complexity 373 373
=============================================
Files 237 37 -200
Lines 11570 1972 -9598
Branches 2174 0 -2174
=============================================
- Hits 2595 1261 -1334
+ Misses 8975 711 -8264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
added
4. to release
|
/backport to stable4.3 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable3.5 |
|
@tcitworld Please fix php-cs issues: https://github.com/nextcloud/calendar/actions/runs/4859057851/jobs/8661205778?pr=5184 |
… through PublicTemplateResponse The public calendar view used 'base' Template responses, preventing the footer that's being used on other public sharing pages from showing. This makes use of PublicTemplateResponse to show it automatically. It's however hidden on embed view. Reference: https://help.nextcloud.com/t/feature-request-impressum-and-privacy-declaration-links/161162 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
public-page-for-calendar
branch
from
4b5edee
to
3a42cf6
Compare
backportbot-nextcloud
bot
removed
the
backport-request
tcitworld
added a commit
that referenced
this pull request
May 22, 2023
Regression from #5184 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
May 25, 2023
Regression from #5184 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
May 25, 2023
Regression from #5184 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public calendar view used 'base'
Templateresponses, preventing the footer that's being used on other public sharing pages from showing. This makes use ofPublicTemplateResponseto show it automatically. It's however hidden (unchanged) on embed view.Reference: https://help.nextcloud.com/t/feature-request-impressum-and-privacy-declaration-links/161162