Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable3.5] fix(Public-Sharing): Show footer with server details and eventual ToS through PublicTemplateResponse #5186

Closed
wants to merge 1 commit into from

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 2, 2023

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #5184

… through PublicTemplateResponse

The public calendar view used 'base' Template responses, preventing the footer that's being used on other public sharing pages from showing. This makes use of PublicTemplateResponse to show it automatically. It's however hidden on embed view.

Reference: https://help.nextcloud.com/t/feature-request-impressum-and-privacy-declaration-links/161162
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@backportbot-nextcloud backportbot-nextcloud bot added 4. to release Ready to be released and/or waiting for tests to finish bug Feature: Public sharing labels May 2, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the v3.5.8 milestone May 2, 2023
@st3iny
Copy link
Member

st3iny commented May 2, 2023

Nextcloud 24 is EOL.

@st3iny st3iny closed this May 2, 2023
@st3iny st3iny deleted the backport/5184/stable3.5 branch May 2, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Feature: Public sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants