Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable3.5] Fix issue with Attendee not being string crashing tooltip #5196

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5170

@backportbot-nextcloud backportbot-nextcloud bot added the 4. to release Ready to be released and/or waiting for tests to finish label May 4, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the v3.5.8 milestone May 4, 2023
@miaulalala miaulalala requested a review from st3iny June 29, 2023 10:15
masonbrothers and others added 3 commits July 6, 2023 17:49
Signed-off-by: Mason Brothers <brothers.mason@gmail.com>
Nice!

Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Mason Brothers <masonbrothers@users.noreply.github.com>
Signed-off-by: Mason Brothers <masonbrothers@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (6ec2e4b) 20.29% compared to head (8350106) 20.34%.

Additional details and impacted files
@@              Coverage Diff              @@
##           stable3.5    #5196      +/-   ##
=============================================
+ Coverage      20.29%   20.34%   +0.05%     
=============================================
  Files            186      186              
  Lines           6342     6346       +4     
  Branches        1032     1034       +2     
=============================================
+ Hits            1287     1291       +4     
  Misses          5055     5055              
Flag Coverage Δ
javascript 20.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/attendee.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st3iny
Copy link
Member

st3iny commented Sep 5, 2023

XML linter failure is unrelated.

@st3iny st3iny merged commit af21e82 into stable3.5 Sep 5, 2023
23 of 24 checks passed
@st3iny st3iny deleted the backport/5170/stable3.5 branch September 5, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants