-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with Attendee not being string crashing tooltip #5170
Merged
miaulalala
merged 3 commits into
nextcloud:main
from
masonbrothers:fix-attendee-not-string
May 4, 2023
Merged
Fix issue with Attendee not being string crashing tooltip #5170
miaulalala
merged 3 commits into
nextcloud:main
from
masonbrothers:fix-attendee-not-string
May 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masonbrothers
force-pushed
the
fix-attendee-not-string
branch
from
April 28, 2023 17:38
7ce0fb3
to
f00c9ff
Compare
Signed-off-by: Mason Brothers <brothers.mason@gmail.com>
masonbrothers
force-pushed
the
fix-attendee-not-string
branch
from
April 28, 2023 17:41
f00c9ff
to
ac300db
Compare
tcitworld
approved these changes
May 1, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5170 +/- ##
============================================
+ Coverage 22.42% 22.46% +0.03%
Complexity 373 373
============================================
Files 237 237
Lines 11570 11575 +5
Branches 2174 2176 +2
============================================
+ Hits 2595 2600 +5
Misses 8975 8975
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
miaulalala
added
4. to release
Ready to be released and/or waiting for tests to finish
blocked
This ticket or PR is blocked by another one
and removed
blocked
This ticket or PR is blocked by another one
labels
May 3, 2023
miaulalala
requested changes
May 3, 2023
Nice! Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com> Signed-off-by: Mason Brothers <masonbrothers@users.noreply.github.com>
masonbrothers
commented
May 3, 2023
Signed-off-by: Mason Brothers <masonbrothers@users.noreply.github.com>
miaulalala
approved these changes
May 4, 2023
Thanks for the PR! |
/backport to stable3.5 |
backportbot-nextcloud
bot
added
the
backport-request
A backport was requested for this pull request
label
May 4, 2023
This was referenced May 4, 2023
Thanks a lot \o/ Have a wonderful weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
backport-request
A backport was requested for this pull request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when you upload a new ics file to nextcloud calendar that does not contain attendees.
Since there is an assumption that the attendee is going to be a string (and not undefined), the tooltip crashes when you try to edit an event.
This PR should fix this by coercing non strings to become strings.