Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alarms): also update DISPLAY alarms #6008

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

miaulalala
Copy link
Contributor

Fixes #3040

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala added 3. to review Waiting for reviews bug labels May 15, 2024
@miaulalala miaulalala added this to the v4.8.0 milestone May 15, 2024
@miaulalala miaulalala requested a review from st3iny May 15, 2024 10:50
@miaulalala miaulalala self-assigned this May 15, 2024
@miaulalala
Copy link
Contributor Author

/backport to stabe4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 23.54%. Comparing base (397c78e) to head (b66f96a).
Report is 16 commits behind head on main.

Files Patch % Lines
src/utils/alarms.js 0.00% 1 Missing and 1 partial ⚠️
src/store/calendarObjectInstance.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6008      +/-   ##
============================================
+ Coverage     23.51%   23.54%   +0.03%     
  Complexity      455      455              
============================================
  Files           246      246              
  Lines         11722    11707      -15     
  Branches       2156     2142      -14     
============================================
  Hits           2756     2756              
+ Misses         8650     8637      -13     
+ Partials        316      314       -2     
Flag Coverage Δ
javascript 15.18% <0.00%> (+0.02%) ⬆️
php 58.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny merged commit 5ccf360 into main May 15, 2024
40 of 41 checks passed
@st3iny st3iny deleted the fix/add-alarm-descriptions branch May 15, 2024 14:35
Copy link

backportbot bot commented May 15, 2024

The backport to stabe4.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stabe4.7
git pull origin stabe4.7

# Create the new backport branch
git checkout -b backport/6008/stabe4.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b66f96ab

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6008/stabe4.7

Error: Failed to clone repository: Failed to checkout branches: error: pathspec 'stabe4.7' did not match any file(s) known to git


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request A backport was requested for this pull request bug
Projects
Development

Successfully merging this pull request may close these issues.

VALARM calendar events missing required DESCRIPTION when using Notifications reminders
2 participants