Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to filter files by circles #137

Open
dtygel opened this issue Sep 29, 2017 · 16 comments
Open

Allow users to filter files by circles #137

dtygel opened this issue Sep 29, 2017 · 16 comments
Labels
4. to release enhancement

Comments

@dtygel
Copy link

dtygel commented Sep 29, 2017

Today, the file list view allows users to filter files by tags, but there is no way to list files per circle(s).

We are working on a PR to do this. For this to be possible, we will also need to make a PR to NextCloud Core, including the needed infrastructure in core/js/files/client.js and in apps/dav/lib/Connector/Sabre/FilesReportPlugin.

Our solution involves the creation of a new Method in Circles API V1, which we called getObjectIdsForCircles, and uses another new method, in ShareByCirclesProvider, which retrieves the shares by Circles's Unique Ids.
@dtygel
Copy link
Author

dtygel commented Sep 29, 2017

@viniciuscb

@ArtificialOwl
Copy link
Member

About the Circles API, I know it is missing a function to retrieve the list of the shared items (circles_shares), I think nothing read the information listed in that database right now, and I will work on this.

However this will not be necessary in here.

If you start working on the files from Nextcloud, maybe adding a entry on the left menu:

selection_083

A 'shared by ...' entry that allow your users to filter the file shared by another user, a group or a circle.
This way you use directly the ShareProvider as the shares for the files are in oc_shares and not oc_circles_shares

This would be an interesting feature.

@ArtificialOwl
Copy link
Member

(Are we talking about the same thing in fact ? ;p)

@ArtificialOwl
Copy link
Member

The API to get item shared from a Circle, in 2 versions, safe and not safe: #139

But I am sure it is not needed for this feature.

@ArtificialOwl
Copy link
Member

@dtygel I still like the idea, any update ? :)

@dtygel
Copy link
Author

dtygel commented Oct 19, 2017

@daita Yes! We have a working code, but haven't done the tests yet. If you'd like to see how it's going, we can make a PR, still without the tests. What do you think?

@ArtificialOwl
Copy link
Member

Sure, please do. This would be great for NC13

viniciuscb added a commit to coletivoEITA/server that referenced this issue Oct 19, 2017
@viniciuscb
Created infrastructure to show circles' shared files
789e4ae 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
dtygel referenced this issue in coletivoEITA/circles Oct 19, 2017
@viniciuscb
Creation of panel to see circles' shared files
e04b7e0 
This commit inserts a panel in files visualization to allow filtering files that were shared to one or more circles.
Depends on some other modifications in nextcloud core, that will be referenced in the PR.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
dtygel referenced this issue in coletivoEITA/circles Oct 19, 2017
@viniciuscb
Hide circles that the user is not member
b39762f 
Files-circles-panel: in javascript interface, just show the circles that the current user is member of.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
@dtygel
Copy link
Author

dtygel commented Oct 19, 2017

Above are the 3 commits that make the files' panel work. The first one is in core. The second and third ones are in circles' plugin.

We'll do both PRs this week or on Monday for your review.

@ArtificialOwl
Copy link
Member

Wow, this is nice.

I am cleaning few stuff and I will PR on your fork, but can you please rebase on your side ?

@ArtificialOwl
Copy link
Member

selection_092

@dtygel
Copy link
Author

dtygel commented Oct 20, 2017 •
edited
Loading

Cool that you liked it, @daita . We'll then rebase now to master so that you can create the PR and do the cleanings. Our branch was based on stable12, so we'll create another one.

viniciuscb added a commit to coletivoEITA/server that referenced this issue Oct 20, 2017
@viniciuscb
Created infrastructure to show circles' shared files
253b263 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
@ArtificialOwl
Copy link
Member

ArtificialOwl commented Oct 20, 2017 •
edited
Loading

I don't think I am able to PR on your fork, so this is my work about this:

https://github.com/nextcloud/circles/tree/edit-files-panel

  • I don't want to fill SharebyCirclesProvider, which is a provider for OCP\Share20. Also, I want to rewrite this class to use Db/CircleProviderRequest. So I moved everything there.
  • I renamed to getFilesFromCircles, even the API so you will need to adjust on nextcloud/server
  • Moved templates/css/js to a subfolder.

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Oct 20, 2017 •
edited
Loading

coletivoEITA#2

cleaner, without the merge mess.

@viniciuscb
Copy link
Member

We tested, everything seems fine. Great job!! Should we do a PR of this to circles?

Um abraço!

@ArtificialOwl
Copy link
Member

👍

please, make the PR for circles and nextcloud

This was referenced Oct 25, 2017
Merged
Closed
ArtificialOwl added a commit that referenced this issue Nov 7, 2017
@ArtificialOwl
Merge pull request #141 from coletivoEITA/circles-files-panel
6b92706 
Circles files panel (#137)
@ArtificialOwl
Copy link
Member

@viniciuscb can you check if the integration of this feature is still working on your side ? it seems to be buggy on NC13 and NC14 !

Obrigado

MorrisJobke pushed a commit to nextcloud/server that referenced this issue Nov 2, 2018
@viniciuscb @MorrisJobke
Created infrastructure to show circles' shared files
9199fc1 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
MorrisJobke pushed a commit to nextcloud/server that referenced this issue Mar 12, 2019
@viniciuscb @MorrisJobke
Created infrastructure to show circles' shared files
5396326 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
MorrisJobke pushed a commit to nextcloud/server that referenced this issue Mar 12, 2019
@viniciuscb @MorrisJobke
Created infrastructure to show circles' shared files
f772ee8 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>

Changes to comply to coletivoEITA/circles#2

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
MorrisJobke pushed a commit to nextcloud/server that referenced this issue Mar 12, 2019
@viniciuscb @MorrisJobke
Created infrastructure to show circles' shared files
e5e8d8f 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>

Changes to comply to coletivoEITA/circles#2

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>

Polishing: get files shared to circles in caldav

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
MorrisJobke pushed a commit to nextcloud/server that referenced this issue Mar 12, 2019
@viniciuscb @MorrisJobke
Created infrastructure to show circles' shared files
564a091 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>

Changes to comply to coletivoEITA/circles#2

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>

Polishing: get files shared to circles in caldav

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>

fixing

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

using CIRCLE__PROPERTYNAME

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

mocking getCircleMembership

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

fixing some phpdoc + deprecation

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

fixing propertyname

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
MorrisJobke pushed a commit to nextcloud/server that referenced this issue Mar 12, 2019
@viniciuscb @MorrisJobke
Created infrastructure to show circles' shared files
9bb13fb 
There is a proposal to allow users to filter files shared to circles. This commit is needed to provide the infrastucture for it.

Issue: nextcloud/circles#137

Changes to comply to coletivoEITA/circles#2

Polishing: get files shared to circles in caldav

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4. to release enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ArtificialOwl @viniciuscb @dtygel