Circles files panel (#137) #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
This commit inserts a panel in files visualization to allow filtering files that were shared to one or more circles. Depends on some other modifications in nextcloud core, that will be referenced in the PR. Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
Files-circles-panel: in javascript interface, just show the circles that the current user is member of. Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
moving files/methods around
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
| @@ -534,7 +534,7 @@ private function joinShare(IQueryBuilder &$qb) { | |||
| $qb->addSelect('s.file_source', 's.file_target'); | |||
| /** @noinspection PhpMethodParametersCountMismatchInspection */ | |||
| $qb->from('share', 's') | |||
| ->andWhere($expr->eq('s.share_type', $qb->createNamedParameter(Share::SHARE_TYPE_CIRCLE))) | |||
| ->where($expr->eq('s.share_type', $qb->createNamedParameter(Share::SHARE_TYPE_CIRCLE))) | |||
There was a problem hiding this comment.
my bad, monday morning...
ArtificialOwl
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal and discussion at #137