Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts 2.0.0 #266

Merged
merged 3 commits into from
Oct 3, 2017
Merged

Contacts 2.0.0 #266

merged 3 commits into from
Oct 3, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 26, 2017 •
edited
Loading

  • Remove export version comparison
  • Bump min nextcloud version
  • Changelog update

Fix #144

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added the 2. developing Work in progress label Jul 26, 2017
@skjnldsv skjnldsv added this to the 1.5.4 milestone Jul 26, 2017
@skjnldsv skjnldsv self-assigned this Jul 26, 2017
@codecov
Copy link

codecov bot commented Jul 26, 2017 •
edited
Loading

Codecov Report

Merging #266 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   14.82%   14.86%   +0.03%     
==========================================
  Files          55       55              
  Lines        1221     1211      -10     
==========================================
- Hits          181      180       -1     
+ Misses       1040     1031       -9
Impacted Files Coverage Δ
...s/components/addressBook/addressBook_controller.js 1.19% <ø> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748c945...a71daa3. Read the comment docs.

@skjnldsv skjnldsv changed the title Contacts 1.5.4 Contacts 2.0.0 Aug 8, 2017
MariusBluem
MariusBluem previously requested changes Aug 8, 2017
View reviewed changes
appinfo/info.xml Outdated
@@ -29,8 +29,8 @@
<repository type="git">https://github.com/nextcloud/contacts.git</repository>
<screenshot>https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Contacts/contacts.png</screenshot>
<dependencies>
<owncloud min-version="9.0" max-version="9.2" />
<nextcloud min-version="9" max-version="13" />
<owncloud min-version="9.2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ownCloud tag not needed for Nextcloud 11 🙈

appinfo/info.xml Outdated
<owncloud min-version="9.0" max-version="9.2" />
<nextcloud min-version="9" max-version="13" />
<owncloud min-version="9.2" />
<nextcloud min-version="11" max-version="13" />
</dependencies>
<ocsid>168708</ocsid>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocsid not needed for new AppStore where apps for Nextcloud 11+ are published 😇

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MariusBluem Do you have a doc where all of those are written? I tried to find it but the doc don't seemed to be up-to-date :'(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv https://nextcloudappstore.readthedocs.io/en/latest/developer.html#app-metadata

skjnldsv and others added 3 commits August 21, 2017 21:05
@skjnldsv
Remove export version comparison
50200fb 
Bump min nextcloud version

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
2.0.0
88e0032
@skjnldsv
Fit docs guidelines for nc11+
a71daa3 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

Sooooo, we're good? :D

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 14, 2017
jancborchardt
jancborchardt approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@irgendwie
Copy link
Member

Let me merge this shortly before release!

irgendwie
irgendwie requested changes Sep 14, 2017
View reviewed changes
Copy link
Member

@irgendwie irgendwie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just blocking this for now

@skjnldsv
Copy link
Member Author

xh3n1 approved these changes 27 minutes ago
jancborchardt approved these changes 22 minutes ago View changes
jonatoni approved these changes 33 seconds ago View changes

Feel the pressure @irgendwie 😆

@jonatoni
Copy link
Member

hahahahaha @irgendwie take your time 😛

@skjnldsv
Copy link
Member Author

Wait for #332 pls

@skjnldsv skjnldsv added help wanted Extra attention is needed high High priority and removed help wanted Extra attention is needed labels Sep 17, 2017
@MorrisJobke
Copy link
Member

Wait for #332 pls

It is in 😉

@RainerEmrich
Copy link

Any chance that you release any time soon? I don't see what's still blocking the release.

@skjnldsv
Copy link
Member Author

@RainerEmrich we're on feature freeze. This will be published very soon. We're testing the release to ensure that no bugs were introduced. Feel free to help us test it with the latest nightlies on the homepage. :)

@RainerEmrich
Copy link

Ok, I gave it a try and found a bug immediately #364 . That's really unfortunate, because I need this feature.
Changing back to 1.5.3 restores the sorting functionality.

@skjnldsv
Copy link
Member Author

@RainerEmrich thank you! We'll handle this asap! :)

@irgendwie irgendwie merged commit 49a4992 into master Oct 3, 2017
@irgendwie irgendwie deleted the bump-to-nc11-and-more branch October 3, 2017 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@jonatoni jonatoni jonatoni approved these changes

@irgendwie irgendwie irgendwie approved these changes

@xh3n1 xh3n1 xh3n1 approved these changes

@Henni Henni Awaiting requested review from Henni

@MariusBluem MariusBluem Awaiting requested review from MariusBluem

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews high High priority
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
8 participants
@skjnldsv @irgendwie @jonatoni @MorrisJobke @RainerEmrich @jancborchardt @xh3n1 @MariusBluem