Nicely integrated select box design #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancborchardt
added
3. to review
jancborchardt
requested review from
Henni,
jonatoni,
irgendwie,
xh3n1 and
skjnldsv
skjnldsv
previously requested changes
Sep 15, 2017
css/_details.scss
Outdated
| border: none; | ||
| text-align: right; | ||
| opacity: .5; | ||
| color: #000; |
There was a problem hiding this comment.
Please use server variables! :)
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 14.17% 14.17%
=======================================
Files 55 55
Lines 1263 1263
=======================================
Hits 179 179
Misses 1084 1084Continue to review full report at Codecov.
|
jancborchardt
force-pushed
the
select-styling
branch
2 times, most recently
from
4d4a3f1
to
520eba7
Compare
skjnldsv
requested changes
Sep 15, 2017
skjnldsv
requested changes
Sep 15, 2017
css/_details.scss
Outdated
| color: $color-main-text; | ||
| outline: none; | ||
| } | ||
| detailsitem select:hover, |
There was a problem hiding this comment.
Please also add empty line before rules (travis will fail otherwise)
There was a problem hiding this comment.
Done too :) damn these old habits die hard
jancborchardt
force-pushed
the
select-styling
branch
from
520eba7
to
28e2dbf
Compare
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
select-styling
branch
from
28e2dbf
to
4675275
Compare
|
@skjnldsv addressed the right align too |
xh3n1
approved these changes
Sep 15, 2017
skjnldsv
added
4. to release
|
Thanks for the thorough review @skjnldsv! Makes me feel rusty :D |
|
@jancborchardt Time to code more! :D |
|
@skjnldsv you didn't let me enough time to review it 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More integrated & less boxed in. As chatted about with @Henni :)
Please review @nextcloud/contacts
Before:
After: