-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse multiline ingredients and tools into separate fields #379
Parse multiline ingredients and tools into separate fields #379
Conversation
f3fa615
to
7a080a6
Compare
Now, this is done for textareas, too. There are only frontend parts touched by this PR. @sam-19, as the vue.js magician here, could you have a look at this? |
CHANGELOG.md
Outdated
@@ -48,6 +50,8 @@ | |||
[#358](https://github.com/nextcloud/cookbook/pull/358) @christianlupus | |||
- Avoid recipe are no longer reachable when user changes locales | |||
[#371](https://github.com/nextcloud/cookbook/pull/371) @christianlupus | |||
- Creating new recipe not possible due to null reference | |||
[#378](https://github.com/nextcloud/cookbook/pull/378/) @seyfeb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a leftover from another PR...., right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I merged #378 in there to be able to create new recipes at all. I can remove those lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, #378 should be merged before. All right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I am no Vus.JS magician, I just looked over the general structure. I will request review by @sam-19.
Apart from the small comment above, it looks good to me! |
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
…ntent with newlines is pasted Works for inputs, not for textarea (yet) Signed-off-by: Sebastian Fey <info@sebastianfey.de>
…s and ingredients Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
29b5db9
to
fef3e6d
Compare
In the recipe editor, pasting content with newlines in a tools or ingredients field automatically creates new fields.
For textareas (recipe steps) this is not done.
Closes #325.