Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul CI tests #564

Merged
merged 25 commits into from
Feb 7, 2021
Merged

Overhaul CI tests #564

merged 25 commits into from
Feb 7, 2021

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented Jan 31, 2021 •
edited
Loading

Closes #537

The test environment is updated and enhanced to allow better integration testing

  • Make the run-local.sh script command line parameter aware
  • Trigger pulls/builds from docker explicitly
  • Build a docker image to use as a basis for integration tests
  • Better structure the file for better understandability, define useful chunks of functionality
  • Prepare integration testing using docker + phpunit + setup (bash) script
  • [optional] Build a daily/weekly set of prebuilt docker images on the docker hub for faster test setup (only the dependencies)
  • [optional] run the test routines in a docker container in order to have the same commands on GH actions and locally (?)
  • Allow tests also for unsupported NC versions
  • Update documentation for testing

@christianlupus christianlupus self-assigned this Jan 31, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021 •
edited
Loading

Codecov Report

Merging #564 (217ff45) into master (10178b2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #564   +/-   ##
========================================
  Coverage      1.01%   1.01%           
  Complexity      440     440           
========================================
  Files            13      13           
  Lines          1381    1379    -2     
========================================
  Hits             14      14           
+ Misses         1367    1365    -2
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 1.01% <ø> (+<0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Controller/ConfigController.php 0.00% <0.00%> (ø) 7.00% <0.00%> (ø%)

@christianlupus christianlupus force-pushed the dev/537-overhaul-tests branch 6 times, most recently from e90bccc to ef93793 Compare February 5, 2021 17:03
@christianlupus
Starting to work on testing-code
902e341 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Continue to update the scripts and break into smaller chunks
b64deb0 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Removed a few bugs to setup the code
693d9ce 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Change styling in code coverage reports
ffac408 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Create HTTP and php-fpm containers for integration testing
e4522e7 
Create apache container with php-fpm for integration testing

Signed-off-by: Christian Wolf <github@christianwolf.email>

Added NGINX as http server alternative

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Extract variable definitions into external files
1d8eb35 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Added test code to reset environment using phpunit test cases
c88deb8 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Exclude additional folders from codecov
fc82ed5 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Update Github workflow to use the new structure
7f626c8 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Extract coverage reports from symlink to allow uploads.
a4f1e9f 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Install composer from upstream
b2b3e85 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Allow cold start with empty or not up-to-date vendor folder
34e6f08 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Avoid issue with read-only core mount
e377b4d 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Reduce build verbosity
d3c62ba 
Signed-off-by: Christian Wolf <github@christianwolf.email>

Removed apt-get verbosity

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Work on cloned app codebase to avoid permission issues
e8be931 
Switch to overlay based file structure
Usage of volume and rsync instead of overlay file system.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Passing env variables to docker run script
d3016b6 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Catch issues in local running script as well.
bdf90f0 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Added container to run php scripts directly
736b4cd 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Ignore NC server restrictions for testing
631ee74 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Setting of runner uid/gid in entrypoint
4055711 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Enable pushing of images
95f5b9c 
Added script to build nightly a CI image
By default fetch the latest prebuilt image from docker hub if starting from scratch

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Written help messaged of the parameters
76b9a43 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Rewritten documentation to reflect new structure
18c7bf8 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Added deprectaion notice to Makefile
f291c01 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Added Changelog entry
7c409f3 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus marked this pull request as ready for review February 7, 2021 14:28
@christianlupus
Copy link
Collaborator Author

I will merge this now. I hope it is working as assumed but if errors arise, we will have to tackle them in time.

@christianlupus christianlupus merged commit bc7b808 into master Feb 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the dev/537-overhaul-tests branch February 7, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@christianlupus christianlupus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul of the test environment
1 participant
@christianlupus