Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time unit labels #879

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Add time unit labels #879

merged 4 commits into from
Jan 17, 2022

Conversation

christianlupus
Copy link
Collaborator

Closes #877

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #879 (db81ef2) into master (c2270dd) will not change coverage.
The diff coverage is n/a.

❗ Current head db81ef2 differs from pull request most recent head 0aa16b2. Consider uploading reports for the commit 0aa16b2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   21.22%   21.22%           
=======================================
  Files          20       20           
  Lines        1555     1555           
=======================================
  Hits          330      330           
  Misses       1225     1225           
Flag Coverage Δ
integration 7.07% <ø> (ø)
unittests 14.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jan 17, 2022

Unit Test Results

  22 files    22 suites   9m 29s ⏱️
  66 tests   66 ✔️ 0 💤 0
726 runs  726 ✔️ 0 💤 0

Results for commit 0aa16b2.

♻️ This comment has been updated with latest results.

This reverts commit ceffc31.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit d5d41a3 into master Jan 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/877-time-unit-labels branch January 17, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Show the unit of time next to time inputs
1 participant