Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust board background to new design of tasks app #2166

Closed
wants to merge 1 commit into from

Conversation

simonspa
Copy link
Contributor

@simonspa simonspa commented Aug 1, 2020

Summary

This adjusts the background of boards to be slightly darker, following the recent design change in the Tasks app (nextcloud/tasks#1136). i think the individual cards stick out better from this background.

image

This would of course be quite a change that, I guess, should be discussed (also cc'ing @jancborchardt here...)

Also, with stronger visual distinction between board and app sidebar, it feels like the sidebar elements are too close to its edge.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Simon Spannagel <simonspa@kth.se>
@juliushaertl
Copy link
Member

@jancborchardt What do you think? I think it still could be a bit lighter than the default background-dark

@juliushaertl juliushaertl added this to the ⭐ 1.1.0 milestone Aug 20, 2020
@juliushaertl juliushaertl mentioned this pull request Sep 17, 2020
@juliushaertl juliushaertl modified the milestones: ⭐ 1.1.0, 💥 1.2.0 Oct 2, 2020
@karlitschek
Copy link
Member

Hmm. I'm not sure. Looks a bit boring and old school. ;-) Maybe make the background a bit lighter. Maybe some more rounded corners of the cards. And in general maybe take some inspiration from the new dashboard? @juliushaertl @jancborchardt

@jancborchardt
Copy link
Member

Several points or questions here:

  • Do we really want to go with a non-white background in general? As this will make the Deck app look separate from the rest of Nextcloud apps
  • If we go with non-white, it shouldn’t be so dark. Needs to be an off-white and not grey, like e.g. #f7f9fc (tinted slight blue, should possibly be adjusted based on the primary theming color)
  • Do we even want to go with e.g. simply the background image of the Dashboard?
  • Agree with Frank we can go with more rounding of the cards, like var(--border-radius-large)

@raimund-schluessler
Copy link
Member

For Tasks we introduced a grey background with nextcloud/tasks#1136. Having it equal in Deck would make sense, I think.

The background image from Dashboard could also be nice, then you could choose whether an image or plain color or whatever is shown (ideally complemented by the ability to select a different background color than the primary one for the Dashboard).

@juliushaertl
Copy link
Member

Do we really want to go with a non-white background in general? As this will make the Deck app look separate from the rest of Nextcloud apps

I personally prefer the white one as well, but we have this request from time to time where people suggest to add some more contrast between cards and the background.

If we go with non-white, it shouldn’t be so dark. Needs to be an off-white and not grey, like e.g. #f7f9fc (tinted slight blue, should possibly be adjusted based on the primary theming color)
Agree with Frank we can go with more rounding of the cards, like var(--border-radius-large)

The screenshot in here was a bit outdated, the border radius is already adjusted. Here is an updated one with the slight blue-ish background as you proposed. Would be fine by me this way:

image

Do we even want to go with e.g. simply the background image of the Dashboard?

I personally think that a background image adds a lot of distraction from the actual content, so I'd rather not have this by default at least.

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonspa Mind to adjust that to the proposal above and rebase? :)

@juliushaertl juliushaertl modified the milestones: 1.2.0, 1.3.0 Nov 9, 2020
@juliushaertl
Copy link
Member

Moving the milestone, since we would need a server css variable first as discussed via chat.

@juliushaertl juliushaertl modified the milestones: 1.3.0, 1.2.0 Nov 16, 2020
@juliushaertl juliushaertl removed this from the 1.3.0 milestone Dec 29, 2020
@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2021
@stale stale bot closed this Jul 21, 2021
@ya-d ya-d mentioned this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the background
5 participants