Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due date shortcuts in the datepicker #2710

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Conversation

jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented Jan 7, 2021

grafik

@jakobroehrl
Copy link
Contributor Author

@juliushaertl Could we release this with 1.4?

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@jakobroehrl
Copy link
Contributor Author

This is working fine.
Could we merge it?

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Comment on lines +196 to +197
date.setHours(23)
date.setMinutes(59)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rather use the current time for the entries that are not due today.

Using 23:59 for today is also not ideal but I guess it will be hard to find a good other default time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nextcloud/designers on this one. Any good idea if the user picks a day how we should determine the best time to set then for a due date reminder?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl @jakobroehrl as usual: What do others like e.g. Trello do? :) One could argue for any of various solutions:

  • Use 23:59 (end of day)
  • Use the current time (or e.g. closest half hour to current time)
  • Use 12:00 midday or some other default
  • Remember whatever was used last

But it’s always best to check what another widely used solution does, because that’s what people are used to. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Tools like todoist or ticktick have All Day due dates. So I use 23:59 for today.
Trello uses the now due date.
Meistertask uses 12:00 for the current date.

I would use 23:59. :)

@juliushaertl juliushaertl changed the title Enh/date shortcuts3 Due date shortcuts in the datepicker Jun 25, 2021
@jakobroehrl
Copy link
Contributor Author

@raimund-schluessler
What are your thoughts on this?
I would like to bring this into tasks, too. If we have an consense here.

@jakobroehrl jakobroehrl removed their assignment Oct 29, 2021
@juliushaertl juliushaertl merged commit 4b5aabd into master Nov 5, 2021
@juliushaertl juliushaertl deleted the enh/dateShortcuts3 branch November 5, 2021 17:03
@juliushaertl juliushaertl modified the milestones: 1.5.0, 1.6.0 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants