-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Due date shortcuts in the datepicker #2710
Conversation
b52ff09
to
b7a6028
Compare
@juliushaertl Could we release this with 1.4? |
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
15a6603
to
06de1a7
Compare
This is working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
date.setHours(23) | ||
date.setMinutes(59) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rather use the current time for the entries that are not due today.
Using 23:59 for today is also not ideal but I guess it will be hard to find a good other default time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nextcloud/designers on this one. Any good idea if the user picks a day how we should determine the best time to set then for a due date reminder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliushaertl @jakobroehrl as usual: What do others like e.g. Trello do? :) One could argue for any of various solutions:
- Use 23:59 (end of day)
- Use the current time (or e.g. closest half hour to current time)
- Use 12:00 midday or some other default
- Remember whatever was used last
But it’s always best to check what another widely used solution does, because that’s what people are used to. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo Tools like todoist or ticktick have All Day due dates. So I use 23:59 for today.
Trello uses the now due date.
Meistertask uses 12:00 for the current date.
I would use 23:59. :)
@raimund-schluessler |
date shortcut #2684