return the selector for collections #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dartcafe <github@dartcafe.de>
dartcafe
force-pushed
the
fix/return-selector
branch
from
57c4b42
to
a6516f0
Compare
juliushaertl
approved these changes
Feb 14, 2022
|
Nice catch, thanks for the pull request 👍 |
|
@juliushaertl Just found this unmerged. Was I expected to merge this? If yes, I'll rebase with a new review. |
|
Sorry, totally slipped through here. Yes, this is good to get in of course :) Thanks for your ping. |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled over it, when adding collections to Polls.
Summary
Avoids
TypeError: can't access property "then", e.action() is undefinedwhen adding a board or card as collectionChecklist