Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Timeline" wording with "Activity" in order to be consistent with equivalent contexts throughout Nextcloud #5164

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

Jerome-Herbinet
Copy link
Member

Replace "Timeline" with "Activity" in order to be consistent with other similar UI/UX contexts in Nextcloud (e.g. Files). Also, if you check the app description, the notion is "Activity" and not "Timeline" (description is relevant and is consistent with the "Activity" context).

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Copy link
Member Author

Tried to make "npm run build", but doesn't produce any file to be committed. Not necessary in this case ?

@cypress
Copy link

cypress bot commented Sep 26, 2023

Passing run #1461 ↗︎

0 17 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 97b0eb6 into e8dd287...
Project: Deck Commit: 1ccdb48ab8 ℹ️
Status: Passed Duration: 03:03 💡
Started: Sep 26, 2023 12:36 PM Ended: Sep 26, 2023 12:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Jerome-Herbinet Jerome-Herbinet changed the title Replace "Timeline" with "Activity" Replace "Timeline" wording with "Activity" in order to be consistent with equivalent contexts throughout Nextcloud Sep 26, 2023
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@juliushaertl juliushaertl merged commit 028b4c0 into main Oct 10, 2023
13 of 14 checks passed
@juliushaertl juliushaertl deleted the Jerome-Herbinet-replace-timeline-with-activity branch October 10, 2023 06:38
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants