Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description marker #98

Merged
merged 6 commits into from
Apr 29, 2017
Merged

description marker #98

merged 6 commits into from
Apr 29, 2017

Conversation

artemanufrij
Copy link
Member

description marker

@artemanufrij artemanufrij added this to the 0.1.3 milestone Apr 28, 2017
@artemanufrij
Copy link
Member Author

#73

@artemanufrij artemanufrij self-assigned this Apr 28, 2017
@pixelipo
Copy link
Contributor

Lots of redundant code in that SVG - I suggest you clean it up with this online tool:
https://petercollingridge.appspot.com/svg-editor/

@artemanufrij
Copy link
Member Author

@pixelipo done

Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
@codecov
Copy link

codecov bot commented Apr 29, 2017

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   79.35%   79.35%           
=======================================
  Files          28       28           
  Lines         678      678           
=======================================
  Hits          538      538           
  Misses        140      140

@juliushaertl
Copy link
Member

Thanks @artemanufrij
What do you think about using an icon that is a bit more obvious what it stands for?
There might be more indicators on a card in the future like due date, ... Can we move the icon just below the title of a card? Maybe .icon-rename that is included in Nextcloud would be ok for that?

@artemanufrij
Copy link
Member Author

@juliushaertl give me a moment :)

@artemanufrij
Copy link
Member Author

@juliushaertl It looks like edit button:
screenshot_20170429_122152

@artemanufrij
Copy link
Member Author

or like this:
screenshot_20170429_122418

@juliushaertl
Copy link
Member

The second one looks better 👍

Let's keep it in the upper right corner for now. We can move it below the card title once we have more indicator icons to show. Some padding around the icon would although be nice. 😉

@artemanufrij
Copy link
Member Author

screenshot_20170429_123715

@juliushaertl
Copy link
Member

Great. Let's merge this. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants