Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a message to upgrade client if minimumSupportedDesktopVersion is thrown #6273

Closed
solracsf opened this issue Dec 9, 2023 · 1 comment 路 Fixed by #6405 路 May be fixed by nextcloud/server#43281
Closed

Display a message to upgrade client if minimumSupportedDesktopVersion is thrown #6273

solracsf opened this issue Dec 9, 2023 · 1 comment 路 Fixed by #6405 路 May be fixed by nextcloud/server#43281
Assignees
@camilasan
Labels
enhancement enhancement of a already implemented feature/code 馃崁 2024-Spring

Comments

@solracsf
Copy link
Member

solracsf commented Dec 9, 2023 •
edited
Loading

How to use GitHub

  • Please use the 馃憤 reaction to show that you want to have the same feature implemented.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature description

When minimumSupportedDesktopVersion is set, it simply throws a 403 for unsupported clients.
Instead, a clear message should be displayed on the client stating that

This version of client is unsupported by the server. Minimum supported version is "{minimumSupportedDesktopVersion}". Please, upgrade your client.

or similar. This is much more user friendly than a simple 403 Forbidden.

https://github.com/nextcloud/server/blob/9964bcbfd576e3c0627f9c6bc662b3168d12a80b/config/config.sample.php#L1991-L2004

https://github.com/nextcloud/server/blob/9964bcbfd576e3c0627f9c6bc662b3168d12a80b/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php#L56-L75
@solracsf solracsf added the enhancement enhancement of a already implemented feature/code label Dec 9, 2023
@camilasan camilasan self-assigned this Dec 11, 2023
camilasan added a commit to nextcloud/server that referenced this issue Feb 2, 2024
@camilasan
Update 403 error message.
d5db7bc 
The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
See #nextcloud/desktop/issues/6273

Signed-off-by: Camila <hello@camilasan.com>
@camilasan camilasan mentioned this issue Feb 2, 2024
Open
5 tasks
camilasan added a commit to nextcloud/server that referenced this issue Feb 2, 2024
@camilasan
Update 403 error message.
6e513f7 
The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
See #nextcloud/desktop/issues/6273

Signed-off-by: Camila <hello@camilasan.com>
@camilasan camilasan mentioned this issue Feb 2, 2024
Merged
2 tasks
@camilasan
Copy link
Member

Desktop client PR: #6405
Server PR: nextcloud/server#43281

camilasan added a commit to nextcloud/server that referenced this issue Feb 6, 2024
@camilasan
Update 403 error message.
b9e4df9 
The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
See #nextcloud/desktop/issues/6273

Signed-off-by: Camila <hello@camilasan.com>
camilasan added a commit to nextcloud/server that referenced this issue Feb 8, 2024
@camilasan
Update 403 error message.
7a10ed0 
The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
See #nextcloud/desktop/issues/6273

Signed-off-by: Camila <hello@camilasan.com>
camilasan added a commit to nextcloud/server that referenced this issue Feb 8, 2024
@camilasan
Update 403 error message.
494f87c 
The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
See #nextcloud/desktop/issues/6273

Signed-off-by: Camila <hello@camilasan.com>
camilasan added a commit to nextcloud/server that referenced this issue Feb 22, 2024
@camilasan
Update 403 error message.
53e8c97 
The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
See #nextcloud/desktop/issues/6273

Signed-off-by: Camila <hello@camilasan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilasan camilasan

Labels
enhancement enhancement of a already implemented feature/code 馃崁 2024-Spring
Projects
馃捇 馃 馃崗 Clients team
Archived in project
Milestone
No milestone
3 participants
@camilasan @AndyScherzinger @solracsf