Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: update desktop client unsupported version (403) error message #43281

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Feb 2, 2024

The user should get a more friendly warning when their desktop client version is not supported anymore by the server. See #nextcloud/desktop/issues/6273

Before:

before

After:

after

Systray message

systray

Summary

TODO

  • ...

Checklist

Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests must be fixed.

@solracsf
Copy link
Member

solracsf commented Feb 6, 2024

What about adding a link on the message to customclient_desktop link?
This could lead to a better UX after all (upgrade one-click away!) :)

/**
* This section is for configuring the download links for Nextcloud clients, as
* seen in the first-run wizard and on Personal pages.
*
* Defaults to:
*
* - Desktop client: ``https://nextcloud.com/install/#install-clients``
* - Android client: ``https://play.google.com/store/apps/details?id=com.nextcloud.client``
* - iOS client: ``https://itunes.apple.com/us/app/nextcloud/id1125420102?mt=8``
* - iOS client app id: ``1125420102``
*/
'customclient_desktop' =>
'https://nextcloud.com/install/#install-clients',

@camilasan camilasan force-pushed the feature/minSupportDesktopVerMsg branch 2 times, most recently from b9e4df9 to 7a10ed0 Compare February 8, 2024 17:42
@camilasan
Copy link
Member Author

What about adding a link on the message to customclient_desktop link?
This could lead to a better UX after all (upgrade one-click away!) :)

with-link-2
withlink

@nextcloud/designers what do you think?

@camilasan camilasan force-pushed the feature/minSupportDesktopVerMsg branch from 7a10ed0 to 494f87c Compare February 8, 2024 17:45
@camilasan
Copy link
Member Author

Tests must be fixed.

I don't know how to fix the tests. I tried to run it locally:
An unhandled exception has been thrown:
Exception: Environment not properly prepared

I need help.

@solracsf
Copy link
Member

solracsf commented Feb 8, 2024

@camilasan I was more thinking about a clickable link (if it can be done).
Somethiing like:

The current version of Nextcloud Desktop client is not supported by this server (client version 3.11+ is required).`
Go to Nextcloud Downloads page to download the update.

Otherwise, the full link is too much noise IMO :(

@nimishavijay
Copy link
Member

nimishavijay commented Feb 12, 2024

Agreed with @solracsf that the link could be hidden. What do you think about adding the link to the text "version 3.0.0 or later"? Would that be possible :)

Unable to connect to Nextcloud.
This version of the client is unsupported. Upgrade to version 3.0.0 or later.

@camilasan camilasan force-pushed the feature/minSupportDesktopVerMsg branch from 72aa9f7 to e071f1b Compare February 22, 2024 13:05
The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
See #nextcloud/desktop/issues/6273

Signed-off-by: Camila <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the feature/minSupportDesktopVerMsg branch from e071f1b to 7670c30 Compare February 22, 2024 13:20
@camilasan
Copy link
Member Author

Unable to connect to Nextcloud.
This version of the client is unsupported. Upgrade to version 3.0.0 or later.

done, please review @solracsf

Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. 👍
Maybe just update the 1st post with an updated screenshot of the final version.

@solracsf solracsf changed the title Update 403 error message. enh: update desktop client unsupported version (403) error message Feb 26, 2024
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good if it’s a clickable link like @solracsf suggested. :)

Another detail: In the settings it says "Unable to connect to Nextcloud" and in the notification "Network error" – both of these are different and neither really seem correct for the issue?
Maybe rather it should say "Connection issue" @camilasan?

@camilasan
Copy link
Member Author

camilasan commented Mar 6, 2024

Maybe rather it should say "Connection issue" @camilasan?

I changed it here: nextcloud/desktop#6514

since the message reason may vary, I think 'Connection issue' is better.

@jancborchardt I didn't realize your comment only referred to the strings used in the desktop client. So this PR on the server is actually done.

This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
This was referenced Apr 4, 2024
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a message to upgrade client if minimumSupportedDesktopVersion is thrown
5 participants