Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display dismissed notifications #1062

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Do not display dismissed notifications #1062

merged 2 commits into from
Feb 4, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Feb 1, 2019

Fixes #685

The view doesn't live update for me. But I think that is a different (and less urgent) issue.

To test:

  1. create some notifications for a user (@ mention them in comments for example)
  2. start the client for that user see the notifications in the activities
  3. dismiss a notification on server
  4. wait a little while
  5. switch to account and back to activity

before: All notifications still there
now: only active notifications still there

@rullzer
Do not display dismissed notifications
86251ff 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@camilasan camilasan merged commit 9931977 into master Feb 4, 2019
@MorrisJobke MorrisJobke deleted the enh/notifications/do_not_show_dismissed branch February 5, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@jpnurmi jpnurmi Awaiting requested review from jpnurmi

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
2. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rullzer @camilasan