-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updater: Enhance UI, make build optional #1847
Conversation
- Add checkbox and button to UI - Add new parameter autoUpdateCheck to ConfigFile Signed-off-by: Michael Schuster <michael@schuster.ms>
Signed-off-by: Michael Schuster <michael@schuster.ms>
- Default: BUILD_UPDATER = NO To ease builds for distro packages and contributors (regardless of the specified update URL) - Enable updater build for Drone CI and AppImage builds Signed-off-by: Michael Schuster <michael@schuster.ms>
/backport to stable-2.6 |
The backport to stable-2.6 failed. Please do this backport manually. |
🍒 Cherry-picked to stable-2.6 |
Good stuff! :) Since it both deals with the version/updates, the "Updates" section could eventually be rolled into the "About" part where it shows the version. Something like:
With "Download" being a button. And when you are up to date:
Also shortened the text, and the "Check now" button should be closer to the text – just like above with the "Ask for confirmation before syncing folders larger than …" and the input box. :) |
* Nextcloud.conf is no longer needed as the updater is disabled by default after [1] * Update comments for signing issues [1] nextcloud/desktop#1847 git-svn-id: file:///srv/repos/svn-community/svn@683993 9fca08f4-af9d-4005-b8df-a31f2cc04f65
* Nextcloud.conf is no longer needed as the updater is disabled by default after [1] * Update comments for signing issues [1] nextcloud/desktop#1847 git-svn-id: file:///srv/repos/svn-community/svn@683993 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@jonasgarstick The one in the notification is expected because macOS does not allow to embed links in notifications. For the settings menu I'm not sure. Could you file an issue about it? |
Also: - Remove patch to disable update check, use BUILD_UPDATER=NO flag instead [1] [1] nextcloud/desktop#1847
Also: - Remove patch to disable update check, use BUILD_UPDATER=NO flag instead [1] [1] nextcloud/desktop#1847
Also: - Remove patch to disable update check, use BUILD_UPDATER=NO flag instead [1] [1] nextcloud/desktop#1847
Also: - Remove patch to disable update check, use BUILD_UPDATER=NO flag instead [1] [1] nextcloud/desktop#1847
Also: - Remove patch to disable update check, use BUILD_UPDATER=NO flag instead [1] [1] nextcloud/desktop#1847
UI: Implement auto-update option and update button
Bugfix
Add CMake option
BUILD_UPDATER
to make the updater optionalDefault:
BUILD_UPDATER
=NO
To ease builds for distro packages and contributors (regardless of the specified update URL)
Enable updater build for Drone CI and AppImage builds
Next steps (follow-up PRs)