Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater: Enhance UI, make build optional #1847

Merged
merged 3 commits into from Mar 10, 2020
Merged

Updater: Enhance UI, make build optional #1847

merged 3 commits into from Mar 10, 2020

Conversation

misch7
Copy link
Member

@misch7 misch7 commented Mar 9, 2020

Screenshot from 2020-03-09 04-23-39

UI: Implement auto-update option and update button

  • Add checkbox and button to UI
  • Add new parameter autoUpdateCheck to ConfigFile

Bugfix

  • Fix OCUpdater: Also change status on network error or invalid XML

Add CMake option BUILD_UPDATER to make the updater optional

  • Default: BUILD_UPDATER = NO

    To ease builds for distro packages and contributors (regardless of the specified update URL)

  • Enable updater build for Drone CI and AppImage builds

Next steps (follow-up PRs)

  • Resurrect auto-update functionality (macOS (Sparkle) work in progress, Windows next)
  • Add support for update channels: stable, beta

- Add checkbox and button to UI
- Add new parameter autoUpdateCheck to ConfigFile

Signed-off-by: Michael Schuster <michael@schuster.ms>
Signed-off-by: Michael Schuster <michael@schuster.ms>
- Default: BUILD_UPDATER = NO

  To ease builds for distro packages and contributors (regardless of the specified update URL)

- Enable updater build for Drone CI and AppImage builds

Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7
Copy link
Member Author

misch7 commented Mar 10, 2020

/backport to stable-2.6

@backportbot-nextcloud
Copy link

The backport to stable-2.6 failed. Please do this backport manually.

@misch7
Copy link
Member Author

misch7 commented Mar 10, 2020

🍒 Cherry-picked to stable-2.6

@jancborchardt
Copy link
Member

Good stuff! :) Since it both deals with the version/updates, the "Updates" section could eventually be rolled into the "About" part where it shows the version. Something like:

Version 2.6.3. Update to 2.6.4 available: [ Download ]
[x] Automatically check for updates [ Check now ]

With "Download" being a button. And when you are up to date:

Version 2.6.4, up to date.
[x] Automatically check for updates [ Check now ]

Also shortened the text, and the "Check now" button should be closer to the text – just like above with the "Ask for confirmation before syncing folders larger than …" and the input box. :)

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 18, 2020
* Nextcloud.conf is no longer needed as the updater is disabled by default after [1]
* Update comments for signing issues

[1] nextcloud/desktop#1847


git-svn-id: file:///srv/repos/svn-community/svn@683993 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 18, 2020
* Nextcloud.conf is no longer needed as the updater is disabled by default after [1]
* Update comments for signing issues

[1] nextcloud/desktop#1847

git-svn-id: file:///srv/repos/svn-community/svn@683993 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@jonasgarstick
Copy link

So is this enhancement gone again? (can only speak for macOS)

nc-update-download
notification

@FlexW
Copy link

FlexW commented May 3, 2021

@jonasgarstick The one in the notification is expected because macOS does not allow to embed links in notifications. For the settings menu I'm not sure. Could you file an issue about it?

@jonasgarstick
Copy link

Thanks for your comment @FlexW#3254

mdkcore0 added a commit to mdkcore0/void-packages that referenced this pull request May 30, 2023
Also:
- Remove patch to disable update check, use BUILD_UPDATER=NO flag
  instead [1]

[1] nextcloud/desktop#1847
mdkcore0 added a commit to mdkcore0/void-packages that referenced this pull request May 30, 2023
Also:
- Remove patch to disable update check, use BUILD_UPDATER=NO flag
  instead [1]

[1] nextcloud/desktop#1847
classabbyamp pushed a commit to void-linux/void-packages that referenced this pull request Jun 9, 2023
Also:
- Remove patch to disable update check, use BUILD_UPDATER=NO flag
  instead [1]

[1] nextcloud/desktop#1847
sirkhancision pushed a commit to sirkhancision/void-packages that referenced this pull request Jun 10, 2023
Also:
- Remove patch to disable update check, use BUILD_UPDATER=NO flag
  instead [1]

[1] nextcloud/desktop#1847
sirkhancision pushed a commit to sirkhancision/void-packages that referenced this pull request Jun 12, 2023
Also:
- Remove patch to disable update check, use BUILD_UPDATER=NO flag
  instead [1]

[1] nextcloud/desktop#1847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants