Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless virtual, better use override only #1989

Merged
merged 1 commit into from
May 20, 2020
Merged

Remove useless virtual, better use override only #1989

merged 1 commit into from
May 20, 2020

Conversation

er-vin
Copy link
Member

@er-vin er-vin commented May 18, 2020

Signed-off-by: Kevin Ottens kevin.ottens@nextcloud.com

Remove useless virtual, better use override only
9328a4b 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
sbeyer
sbeyer approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@sbeyer sbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I checked that this is the only location where virtual and override occurs.

misch7
misch7 approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@misch7 misch7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@misch7 misch7 merged commit 3d2de4f into master May 20, 2020
@misch7 misch7 deleted the remove_redundant_virtual branch May 20, 2020 01:27
@misch7
Copy link
Member

misch7 commented May 20, 2020

/backport to stable-2.6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 20, 2020
Merged
@misch7 misch7 added this to the 2.6.5 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbeyer sbeyer sbeyer approved these changes

@misch7 misch7 misch7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.5
Development

Successfully merging this pull request may close these issues.
3 participants
@er-vin @misch7 @sbeyer