Display the correct default permissions when creating a share. #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
force-pushed
the
display-default-permissions-share
branch
from
d28ca51
to
699e886
Compare
er-vin
reviewed
Jul 8, 2020
| @@ -28,7 +28,7 @@ enum SharePermission { | |||
| SharePermissionCreate = 4, | |||
| SharePermissionDelete = 8, | |||
| SharePermissionShare = 16, | |||
| SharePermissionDefault = 1 << 30 | |||
| SharePermissionDefault = 31 | |||
There was a problem hiding this comment.
I wonder, isn't it badly named now? From your description the default can be 31 or 1 depending if it's a public share or not.
I don't know that area well though, so it might just be me being confused.
camilasan
force-pushed
the
display-default-permissions-share
branch
from
699e886
to
e5803fc
Compare
- The default displayed was not in sync with the server because the client was setting permissions when creating a share while it should get the default permissions from the server to display it to the user first. Signed-off-by: Camila <hello@camila.codes>
camilasan
force-pushed
the
display-default-permissions-share
branch
from
e5803fc
to
d7a1367
Compare
misch7
approved these changes
Jul 8, 2020
|
/backport to stable-2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the client was setting permissions when creating a share while it
should get the default permissions from the server to display it to the
user first.
server:
client:
