Remove "This includes" due to tooltip order #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
approved these changes
Sep 21, 2020
|
/rebase |
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com>
github-actions
bot
force-pushed
the
remove-this-includes
branch
from
ea0bced
to
3a53afd
Compare
er-vin
approved these changes
Sep 21, 2020
|
AppImage file: Nextcloud-PR-2431-3a53afd704b6cdbbb0a685c46ec41db7e3721f75-x86_64.AppImage |
|
/backport to stable-3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the tooltip update, I noticed that the "info" message tooltip has "This Includes:" as the info text, which looks a bit odd now.
I thus removed the text. However, I'm not sure about other places this could happen.
One possible other way to fix this would be to switch the info and title in the tooltip, but then that wouldn't match the list view unless that was also swapped as well.
(I'm not sure how this should be designed, or if this current fix is ok)