User status bug fixing...

[camilasan]

• address Kevin's last comments in the PR Status feature #2505
• if there is no emoji in the status message (and for the default "Online, offline, etc" ones), the text is a bit off to the right, not left-aligned with name and server link
• the menu icon for the other apps is missing on the right next to the Talk icon, and Talk icon moved over? Unrelated to status, but visible in the screenshots and also in the release it seems
  

[er-vin]

@er-vin Alrighty then. Never thought about that, but, it should also be simple to check that the enum index is within bounds and has a corresponding `QString` assigned to it.

Well, that's why I mentioned "in the middle". Typically sometimes you'd have something which is still within bounds but without the message you expect. Of course in other cases you'd have something outside of bounds but this is easier to catch.

Now, if we are talking about `enum class`, why not make that `enum Status` an `enum class Status` instead, @camilasan ? :)

Yes good point. Thought I mentioned it in the past but probably forgot.

[allexzander]

Well, that's why I mentioned "in the middle". Typically sometimes you'd have something which is still within bounds but without the message you expect. Of course in other cases, you'd have something outside of bounds but this is easier to catch.
@er-vin In one of my past jobs, we were using a command-line tool that would generate all that's needed for enum (array with strings and conversion functions). So, adding an enum index in the middle would just be a simple insertion into an enum template file which is then fed to a command-line tool during the build :)

[er-vin]

@er-vin In one of my past jobs, we were using a command-line tool that would generate all that's needed for enum (array with strings and conversion functions). So, adding an enum index in the middle would just be a simple insertion into an enum template file which is then fed to a command-line tool during the build :)

Yes, tooling is a way to escape this. We got that for free in some way with Q_ENUM. The difficulty here is the translated strings, Q_ENUM won't help you for this and so you're back to square one...

[allexzander]

Looks fine. Let's fix QML warnings in 3.2.1.

[er-vin]

Looks fine. Let's fix QML warnings in 3.2.1.

This + move stringToEnum and enumToString in an anonymous namespace in the cpp file. From the other comments I think that one fell through the cracks.

[allexzander]

/rebase

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-3069-1ca0ea49dd9fee42af0b0a4d8281941afb1f163e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.