Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

takes ECMCoverageOption from ECM to enable code coverage analysis #3339

Merged
merged 1 commit into from
Jul 28, 2021
Merged

takes ECMCoverageOption from ECM to enable code coverage analysis #3339

merged 1 commit into from
Jul 28, 2021

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu_gallien@yahoo.fr

@mgallien
Copy link
Collaborator Author

This is missing the fact that we would run CI with this enabled and would archive the result.
That would be for later but I am open to early comment such that I do not waste too much time

@mgallien mgallien marked this pull request as ready for review July 26, 2021 16:06
@mgallien
Copy link
Collaborator Author

/rebase

@allexzander
Copy link
Contributor

thanks

@mgallien
Copy link
Collaborator Author

/rebase

@mgallien
Copy link
Collaborator Author

/rebase

@mgallien
takes ECMCoverageOption from ECM to enable code coverage analysis
f9bfd8a 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3339-f9bfd8adec6c0a7bf1d9d57b9be2f59d3557e5fd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 6ac719d into master Jul 28, 2021
@mgallien mgallien deleted the ci/addCodeCoverage branch July 28, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@allexzander allexzander allexzander approved these changes

@FlexW FlexW FlexW approved these changes

@er-vin er-vin Awaiting requested review from er-vin

@nicolasfella nicolasfella Awaiting requested review from nicolasfella

Assignees
No one assigned
Labels
1. to develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgallien @allexzander @nextcloud-desktop-bot @camilasan @FlexW