Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file name and line number #3902

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

FlexW
Copy link

@FlexW FlexW commented Oct 18, 2021

No description provided.

@mgallien
Copy link
Collaborator

why do you need this ?

@FlexW
Copy link
Author

FlexW commented Oct 19, 2021

@mgallien Because of log statements that are not unique or only log a variable. I know it would be better to always log context around a statement, but it's more practically at the moment to enable that directly.

@FlexW
Copy link
Author

FlexW commented Oct 19, 2021

/rebase

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3902-1156d82594a4a692f0c16c433a6c2b4bc065d6c2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 597e29e into master Oct 19, 2021
@mgallien mgallien deleted the feature/log-filename-linenum branch October 19, 2021 19:33
@mgallien mgallien added this to the 3.4.0 milestone Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants