Fix thumbnails for new files made while client open #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
approved these changes
Apr 14, 2022
allexzander
approved these changes
Apr 18, 2022
|
/rebase |
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
mgallien
force-pushed
the
bugfix/new-thumbnails
branch
from
fa57d6b
to
7b65c1c
Compare
|
AppImage file: Nextcloud-PR-4428-7b65c1ceedd70efa4e8e6af24ee9727d3b4d4a5e-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would try to pull thumbnails for local changes made while the client was open. If this change was the creation of a new file, we would try to pull the thumbnail from the server before the thumbnail had been created there, leaving us with a blank square rather than the icon that we want.
This PR fixes this behaviour, ensuring that new files get an icon instead of a blank square